There are 2 issues here:
1) A typo: instead of `noreferrer` there is `nofererer` in the code twice
2) Minified js does not match the current js, which could be a security risk as obviously nobody checked what's in there. I just created it with the fixed attributes, PLEASE ALWAYS CHECK THAT BEFORE MERGING!

You could also just remove the minified version from the module. This would be even better i guess.

CommentFileSizeAuthor
extlink-noreferrer.patch7.77 KBarthur_lorenz

Comments

arthur_lorenz created an issue. See original summary.

Status: Needs review » Needs work

The last submitted patch, extlink-noreferrer.patch, failed testing. View results

elachlan’s picture

elachlan commented

Your patch failed testing. please reroll.

elachlan’s picture

elachlan commented
Related issues: +#2929552: Remove minified js file
elachlan’s picture

elachlan commented
Priority: Critical » Normal

  • elachlan committed b19721a on 7.x-1.x 
    Issue #2955326 by arthur_lorenz: Fix ref="noreferrer"
elachlan’s picture

elachlan commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.