Creating an issue off the comments by berdir in https://www.drupal.org/project/extlink/issues/2921495

This is one of the few modules I've seen that provides a minified javascript file as part of the source code. In doing this, it must make it harder to maintain this project in that every open issue with a patch that changes the javascript has to be re-rolled against the latest code to provide that file.

CommentFileSizeAuthor
#5 2929552-5.patch3.32 KBdpagini
#2 2929552-2.patch0 bytesdpagini

Comments

dpagini created an issue. See original summary.

dpagini’s picture

dpagini commented
StatusFileSize
new 2929552-2.patch0 bytes
dpagini’s picture

dpagini commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: 2929552-2.patch, failed testing. View results

dpagini’s picture

dpagini commented
Status: Needs work » Needs review
StatusFileSize
new 2929552-5.patch3.32 KB

Hmm... messed up that patch, here's another one.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Thanks, forgot about this. Lets do this :)

  • elachlan committed d40fcd2 on 8.x-1.x authored by dpagini 
    Issue #2929552 by dpagini: Remove minified js file
elachlan’s picture

elachlan commented
Status: Reviewed & tested by the community » Fixed

done.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.