Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
22 Mar 2018 at 10:11 UTC
Updated:
4 Sep 2018 at 17:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
Deepthi kumari commentedHi,
Fixed coding standard issues. Applied the patch. Needs review.
Comment #3
dalanz commentedI applied the patch and retested the module. All works fine. Thank you very much.
Comment #4
dalanz commentedI merged the patch #2 and the module is ready for testing.
git clone --branch 8.x-1.x https://git.drupal.org/project/crisis_mode.gitThanks
Comment #5
altagrade commentedThe https://pareview.sh/pareview/https-git.drupal.org-project-crisis_mode.git is showing:
Comment #6
dalanz commentedI fixed the line length issue in readme.txt and committed the changes back. Again ready for testing.
Thank you.
Comment #7
avpadernoTo the reviewers: Please set the priority to Normal after reviewing the project.
Comment #8
sleitner commentedAutomated Review
Review of the 8.x-1.x branch (commit c6cb8b8):
This automated report was generated with PAReview.sh, your friendly project application review script.
Manual Review
The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.
If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.
This review uses the Project Application Review Template.
Comment #9
avpadernoThank you for your contribution!
I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.