As per #2954868

There is no need to have Modal Block entity. This needs to be removed from the folder.

CommentFileSizeAuthor
#7 code-cleanup-2955122-8.patch6.87 KBchishah92
#6 Screenshot from 2018-03-22 15-27-55.png310.17 KBnishantkumar155
#5 code-cleanup-2955122-5.patch6.02 KBchishah92

Comments

neeraprajapati created an issue. See original summary.

chishah92’s picture

chishah92 commented
Assigned: Unassigned » chishah92
Status: Active » Needs work

Thanks for creating the issue, will add a patch to clean the code

chishah92’s picture

chishah92 commented
Parent issue: » #2954868: No Content visible in modal block
chishah92’s picture

chishah92 commented
Status: Needs work » Needs review

Patch which removes all unnecessary code according to new workflow

chishah92’s picture

chishah92 commented
StatusFileSize
new code-cleanup-2955122-5.patch6.02 KB
nishantkumar155’s picture

nishantkumar155 commented
Status: Needs review » Needs work
StatusFileSize
new Screenshot from 2018-03-22 15-27-55.png310.17 KB

@chishah92 patch work perfectly but , it would be great if you remove below code from .install file

 \Drupal::configFactory()
    ->getEditable('block_content.type.modal_block')
    ->delete();
  \Drupal::configFactory()
    ->getEditable('core.entity_form_display.block_content.modal_block.default')
    ->delete();
  \Drupal::configFactory()
    ->getEditable('core.entity_view_display.block_content.modal_block.default')
    ->delete();
  \Drupal::configFactory()
    ->getEditable('field.field.block_content.modal_block.field_modal_blocks')
    ->delete();
  \Drupal::configFactory()
    ->getEditable('field.storage.block_content.field_modal_blocks')
    ->delete();
chishah92’s picture

chishah92 commented
Status: Needs work » Needs review
StatusFileSize
new code-cleanup-2955122-8.patch6.87 KB

Yes, i found that after i submitted the patch, have removed in this new patch.

neeraprajapati’s picture

neeraprajapati commented
Status: Needs review » Reviewed & tested by the community

This patch is working fine.

nishantkumar155’s picture

nishantkumar155 commented
Status: Reviewed & tested by the community » Fixed

Thank you @chishah92 and @neeraprajapati .

chishah92’s picture

chishah92 commented
Assigned: chishah92 » Unassigned
Status: Fixed » Closed (fixed)