I created a basic block with some text in body field of that block. I associated the same with a new modal block and placed it in header. I see an blank popup with no content in it.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | no-content-visible-issue-fix-2954868-7.patch | 4.54 KB | chishah92 |
| #6 | Block layout-modal-block.png | 68.54 KB | neeraprajapati |
| #5 | no-content-visible-issue-fix-2954868-5.patch | 3.04 KB | chishah92 |
Comments
Comment #2
chishah92 commentedComment #3
chishah92 commentedWill provide a patch for this
Comment #4
chishah92 commentedThis module development approach is not correct, i have created a block plugin where User will have to place the "Modal Block" and in the block configuration select the block to be shown, instead of multiple addition of blocks.
NOTE : User should not create a custom block of type "Modal Block", This was in the previous workflow
This patch fixes the issue with recommendable approach.
Comment #5
chishah92 commentedComment #6
neeraprajapati commentedCss/js is broken after applying this patch. screenshot has been attached. Also popup is not coming while going to place block in any region.
Comment #7
chishah92 commentedPlease review this patch, that issue is fixed.
Comment #8
neeraprajapati commentedThis patch works fine.
Now it is required to update the README.txt and there is also no need to use Field formatter and Block entity. Being a maintainer i will be creating two issues related to the same.
Comment #9
chishah92 commentedPlease make me the Co-maintainer of this project, so that i work further on the enhancement
Comment #11
nishantkumar155 commentedThank you @chishah92 and @neeraprajapati .
Comment #12
chishah92 commented