I created a basic block with some text in body field of that block. I associated the same with a new modal block and placed it in header. I see an blank popup with no content in it.

Comments

chishah92 created an issue. See original summary.

chishah92’s picture

Issue summary: View changes
chishah92’s picture

Assigned: Unassigned » chishah92
Status: Active » Needs work

Will provide a patch for this

chishah92’s picture

Status: Needs work » Needs review

This module development approach is not correct, i have created a block plugin where User will have to place the "Modal Block" and in the block configuration select the block to be shown, instead of multiple addition of blocks.

NOTE : User should not create a custom block of type "Modal Block", This was in the previous workflow

This patch fixes the issue with recommendable approach.

chishah92’s picture

neeraprajapati’s picture

Status: Needs review » Needs work
StatusFileSize
new68.54 KB

Css/js is broken after applying this patch. screenshot has been attached. Also popup is not coming while going to place block in any region.

chishah92’s picture

Status: Needs work » Needs review
StatusFileSize
new4.54 KB

Please review this patch, that issue is fixed.

neeraprajapati’s picture

Status: Needs review » Reviewed & tested by the community

This patch works fine.

Now it is required to update the README.txt and there is also no need to use Field formatter and Block entity. Being a maintainer i will be creating two issues related to the same.

chishah92’s picture

Please make me the Co-maintainer of this project, so that i work further on the enhancement

nishantkumar155’s picture

Status: Reviewed & tested by the community » Fixed

Thank you @chishah92 and @neeraprajapati .

chishah92’s picture

Assigned: chishah92 » Unassigned
Status: Fixed » Closed (fixed)