Problem/Motivation

The webform_bootstrap module fixes minor issue with webform elements using hook_webform_element_ELEMENT_TYPE_alter(). This hook is not being applied to composite subelements.

Proposed resolution

Add invoked alter to all composite sub-elements.

Remaining tasks

  • Create test form
  • Add alter hook
  • Fix broken tests

Screenshot


CommentFileSizeAuthor
#8 2953420-8.patch16.58 KBjrockowitz
#5 Screen Shot 2018-03-15 at 4.55.08 PM.png282.83 KBjrockowitz
#4 2953420-5.patch9.86 KBjrockowitz
#2 Issue 2953420 Composite sub elements are not alterable via hook_webform_element_ELEMENT_TYPE_alter Webform Demo Site.png257.53 KBjrockowitz
#2 webform.webform.issue_2953420.yml3.35 KBjrockowitz

Comments

jrockowitz created an issue. See original summary.

jrockowitz’s picture

jrockowitz commented
Issue summary: View changes
StatusFileSize
new webform.webform.issue_2953420.yml3.35 KB
new Issue 2953420 Composite sub elements are not alterable via hook_webform_element_ELEMENT_TYPE_alter Webform Demo Site.png257.53 KB

  • jrockowitz committed 3f3885f on 2953420-subelement-alter 
    Issue #2953420: Composite sub-elements are not alterable via...
jrockowitz’s picture

jrockowitz commented
Status: Active » Needs review
StatusFileSize
new 2953420-5.patch9.86 KB
jrockowitz’s picture

jrockowitz commented
StatusFileSize
new Screen Shot 2018-03-15 at 4.55.08 PM.png282.83 KB

Here is the buttons element correctly displayed w/o the Panel wrapper in the Bootstrap theme after the patch has been applied.

  • jrockowitz committed e0d756e on 2953420-subelement-alter 
    Issue #2953420: Composite sub-elements are not alterable via...

  • jrockowitz committed 974fb21 on 2953420-subelement-alter 
    Issue #2953420: Composite sub-elements are not alterable via...
jrockowitz’s picture

jrockowitz commented
StatusFileSize
new 2953420-8.patch16.58 KB
jrockowitz’s picture

jrockowitz commented
Status: Needs review » Reviewed & tested by the community

  • jrockowitz committed ebf9bea on 8.x-5.x 
    Issue #2953420 by jrockowitz: Composite sub-elements are not alterable...
jrockowitz’s picture

jrockowitz commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.