Menu Item Extras adds fields for the Menu Items, and place all fields upon the menu item edit form. In the 8.x-2.x was implemented the full management system for the Menu Content Link entity. This module provided with tests coverage.

Project page:
https://www.drupal.org/project/menu_item_extras.

Repo:
git clone --branch 8.x-2.x https://git.drupal.org/project/menu_item_extras.git

https://pareview.sh/pareview/https-git.drupal.org-project-menu_item_extras.git-8.x-2.x

Comments

voleger created an issue. See original summary.

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented
Issue summary: View changes
voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented
Priority: Normal » Major
mattshoaf’s picture

mattshoaf
he/him
Primary language English
Location Kansas City, MO, USA
commented
Priority: Major » Normal
Status: Needs review » Reviewed & tested by the community

I downloaded code and installed on a minimal drupal 8 install.

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage
Code style and Drupal API usage looks good.
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Reviewed & tested by the community » Needs review

Let's get a second review.

ozin’s picture

ozin
Primary language Ukrainian
commented
Priority: Normal » Major
Issue tags: +PAreview: review bonus
ozin’s picture

ozin
Primary language Ukrainian
commented

@mattshoaf thanks for the review.

ozin’s picture

ozin
Primary language Ukrainian
commented
Issue tags: -PAreview: review bonus
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Priority: Major » Normal
teemuaro’s picture

teemuaro commented
Status: Needs review » Reviewed & tested by the community

I installed the module and it seems to work nicely. Here's my review.

Automated Review

Pareview.sh shows basically no problems: https://pareview.sh/pareview/https-git.drupal.org-project-menu_item_extr...

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage
Code seems to follow Drupal style guides and is clean and easy to read.

This review uses the Project Application Review Template.

visabhishek’s picture

visabhishek commented
Status: Reviewed & tested by the community » Fixed

Thank you Oleh Vehera for your contribution!

I am going to update your account so you can opt into security advisory coverage now.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.

Thank you, also, for your patience with the review process.

Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

visabhishek’s picture

visabhishek commented

Assigning credits.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.