For unlimited items in media type field it is necessary to correct the markup for the form of Quick Edit. Please see Screenshot_1.png and Screenshot_2.png.
There's a possibility, that the same situation is for all fields with for unlimited items. Need test.

CommentFileSizeAuthor
#19 resultquickedit.png2.93 MBskt-001
#16 2952901-16.patch426 bytesranjith_kumar_k_u
#7 ResultScreenshot.png243.21 KBalena_stanul
#6 ResultScreenshotRtL.png142.52 KBalena_stanul
#5 fixed_css_issue-2952901-5.patch426 bytesDeepthi kumari
Screenshot_2.png34.44 KBalena_stanul
Screenshot_1.png65.72 KBalena_stanul

Comments

alena_stanul created an issue. See original summary.

alena_stanul’s picture

alena_stanul commented
alena_stanul’s picture

alena_stanul commented
Status: Active » Needs work
alena_stanul’s picture

alena_stanul commented
Issue tags: +Novice
Deepthi kumari’s picture

Deepthi kumari commented
Status: Needs work » Needs review
StatusFileSize
new fixed_css_issue-2952901-5.patch426 bytes

Hi,

I have fixed the CSS issue. Applied the patch. Needs review.

alena_stanul’s picture

alena_stanul commented
StatusFileSize
new ResultScreenshotRtL.png142.52 KB

Looks good. See ResultScreenshot.png.
But if you change direction to 'ltr', the drag-and-drop cursor will stuck to the right border of the table. Can we change this within this task? See ResultScreenshotRtL.png.

alena_stanul’s picture

alena_stanul commented
StatusFileSize
new ResultScreenshot.png243.21 KB
anmolgoyal74’s picture

anmolgoyal74 commented
Status: Needs review » Reviewed & tested by the community

The patch #5 looks good to me. marking it RTBC.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Needs review

Hm, you are making this change to

.quickedit-form {
  position: absolute;
  z-index: 300;
  max-width: 35em;
}

Are you sure there is no side effects of this? Would display: table be appropriate for any kind of quickedit form? In terms of the RTL change, does it look equally bad for the drag-drop widget (I would expect) without this change?

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

ranjith_kumar_k_u’s picture

ranjith_kumar_k_u commented
StatusFileSize
new 2952901-16.patch426 bytes

Updated

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

spokje’s picture

spokje
Primary language Dutch
commented
Project: Drupal core » Quick Edit
Version: 9.4.x-dev » 1.0.x-dev
Component: quickedit.module » Code

Due to Quickedit being moved out of Drupal Core and into a Contrib Module, moving this issue to the Contrib Module queue.

skt-001’s picture

skt-001 commented
StatusFileSize
new resultquickedit.png2.93 MB

for version 10, its working fine.

skt-001’s picture

skt-001 commented
Status: Needs review » Reviewed & tested by the community

moving to rtbc as share the SS after applying the patch.

  • vladimiraus committed 9e9847cf on 1.0.x 
    feat: #2952901 For unlimited items in media type field 'inputs' are...
vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Reviewed & tested by the community » Fixed

Thank you. Committed. 🍻

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • vladimiraus committed 9e9847cf on 2.0.x 
    feat: #2952901 For unlimited items in media type field 'inputs' are...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.