Warning notice in php 7.2

Proposed patch for it.

One space is added, and the patch is renamed.

I have tested it #5 working fine

Yup, #5 seems to do the trick.

RTBC: we might find something else > followup. (we need to move on PHP7)
Task: PHP7 ain't a bug.

count((array)$array)..

The patch in #5 works!

I found the same problem was fixed in the core with the patch #2885610-19: [PHP 7.2] Avoid count() calls on uncountable variables . Maybe it's better to have the same change with the core and I adjusted the patch #5 a little. (Sorry to move back to Needs review.)

+1 It looks good to me. Thanks.

Regarding #9, on this part of the interdiff:

-      if (is_array($cols) && !empty($cols)) {
+      if (is_array($cols) && count($cols)) {

Why would you use count() instead of !empty() when the only thing we want to know is if it is not empty.
While the count works it seems like the wrong tool for the job.

The empty function could be more performant and/or better optimized. Although I don't know the current benchmarks regarding count() vs empty().

@paulvandenburg:

Why would you use count() instead of !empty() when the only thing we want to know is if it is not empty.

Because the core uses count() in the same line in theme_table() and the performance is not the main interest here, I thought.

I understand your point. I also think empty() is better if this part is not related to the core code and this line is called many times in a request. In my opinion, using the same logic with the core as much as possible is more important here for future maintenance though I don't stick to count(). What do you think?

disclaimer: without looking at the code - patch #9 seems to work for me

had a closer look, RTBC

Patch #9 LGTM +1

Tested. +1 RTBC

I've sent a message to the maintainer, if he doesn't respond in 2 weeks, make an official request to take ownership of this project.

Thanks Andrey!

Just adding another confirmation that the patch in #9 resolved the PHP errors in php 7.2.

Looking forward to this patch making it to new release!

Thanks Andrey!

:)