Hi,
thanks for your effort with this module. Really appreciate it, its flexible, yet easy to use.
When I set the Text color to some hex value, the text got the desired value except the headings. These (H1, H2, H3) still have the #FFFFFF set from the CSS.
Maybe the style attribute can be applied to #popup-text –> all the contet will get the color (probably better to use some namespaced class as mentioned in the other issue).
And one sidenote: I'm always confused about the first checkbox – Enable PopUp. I leave it unchecked everytime I use this module, because I don't wan't a popup window in the middle of the screen. So maybe replace popup with more appropriate word (bar??) or change it to Enable Cookie Consent, because thats what the checkbox do. :)
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | eu_cookie_compliance-text-color-not-applied-to-headings-2949588-2.patch | 2.87 KB | svenryen |
Comments
Comment #2
svenryen commentedHi Petr! I moved your issue about the "popup" label to a different issue #2949870: The term 'popup' causes some confusion.
You're right that text color is not handled effectively. In fact, only H2 and P were getting their color set by the module, H1 and H3 were being ignored.
Using simply '#popup-text', like you suggested, wouldn't work, as the H1 specific selector from the theme css would override it.
To give themers more freedom over how they style their markup, I decided to override the css selector '#sliding-popup' which is set by JS (together with h1, h2, h3 and p), and thus will always be available no matter how the twig is themed.
Here's a patch that solves the issue, while still retaining backwards compatibility.
Comment #4
svenryen commentedComment #5
svenryen commented