Closed (fixed)
Project:
Search API
Version:
8.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
28 Feb 2018 at 18:41 UTC
Updated:
20 May 2018 at 15:49 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
capysara commentedComment #3
drunken monkeyThanks for creating this issue and posting your patch!
Looks pretty good already, except for one mistake:
The path needs to be wrapped in an
url()call, I think.But other than that, it looks good, thanks!
Also, it seems not only would this need a port to D8, but we also seem to have neglected to do that for the other issue.
Comment #4
drunken monkeyComment #5
capysara commentedLike this?
Comment #6
drunken monkeyYes, looks great now, thanks a lot!
However, two little tips: When posting patches, please
The former is, apart from being "proper procedure" also needed for the test bot to spring into action.
Comment #8
drunken monkeyTests are green, so: committed.
Thanks again!
Comment #9
capysara commentedThanks for tips!
I'll work on a patch for D8 next.
Comment #10
capysara commentedD8 version
Comment #11
capysara commentedComment #12
drunken monkeyComment #13
drunken monkeyOops, wrong button …
Anyways, thanks a lot for the patch, looks great already!
Just had to re-roll because of #2931730: Adapt to changes in drupal_set_message(). Also, we'll want a test (assertion) for this, and I think using
$index->toUrl()gets us the same URL in a simpler and cleaner manner.Comment #14
borisson_This looks very solid, great work!
Comment #16
drunken monkeyGreat to hear, thanks for reviewing!
Committed.
Thanks again, capysara!