Tokens not substituted in query string

I have the same problem, it only works if there's anything before the token in URL

Please review this. Adding the patch for Drupal core as well. See: https://www.drupal.org/project/drupal/issues/2978657#comment-12647144

I ended up with the following errors:

Error: Uncaught TypeError: Argument 1 passed to Drupal\Core\Utility\Token::replaceArray() must be of the type
array, null given, called in /Users/sohail/Sites/setboxy/modules/contrib/menu_token/menu_token.module on line
393 and defined in /Users/sohail/Sites/setboxy/core/lib/Drupal/Core/Utility/Token.php:278
Stack trace:
#0 /Users/sohail/Sites/setboxy/modules/contrib/menu_token/menu_token.module(393):
Drupal\Core\Utility\Token->replaceArray(NULL, Array, Array, Object(Drupal\Core\Render\BubbleableMetadata))
#1 /Users/sohail/Sites/setboxy/modules/contrib/menu_token/menu_token.module(452):
replace_links_with_tokens(Object(Drupal\token\Token), 'query', Array, Array,
Object(Drupal\Core\Render\BubbleableMetadata))
#2 /Users/sohail/Sites/setboxy/core/lib/Drupal/Core/Extension/ModuleHandler.php(539):
menu_token_menu_links_discovered_alter(Array, NULL, NULL)
#3 /Users/sohail/Sites/setboxy/core/lib/Drupal/Core/Menu/MenuLinkManager.php(167):
Drupal\Core\Extension\ModuleHandler->alter('menu_links_disc...', Array)
#4 /Users/soha in /Users/sohail/Sites/setboxy/core/lib/Drupal/Core/Utility/Token.php, line 278

Closing #2988939: Allow tokens to be used as query parameters as a duplicate.

Patch attached, but this approach is completely different and does not require a core patch.

This patch doesn't work when you have node in your menu link.

Notice: Array to string conversion in Drupal\Core\Theme\ThemeInitialization->getActiveTheme() (line 179 of core/lib/Drupal/Core/Theme/ThemeInitialization.php).

Undefined index: add_query_parameters in menu_token_prepare_context_replacement() (line 427 of modules/contrib/menu_token/menu_token.module).
menu_token_prepare_context_replacement(Array)

@heshanlk you attached a diff but where is a patch??

The patch (which is called diff), works very well for me ;-)
Thank you
I installed it on dev version

Update #12 to be a patch.

Thank you all for your contributions and feedback. Just wanted to note that this issue is more a feature request than a bug report, since we are adding new functionality and interface changes. Also, I'm not sure if Menu Token should handle query strings, since the cache can do all sort of things to freeze some tokens that are sensitive to context. That said, I think that this functionality is more appropriate in Javascript OR that we should handle a few cached use cases. In all cases, we should inform the user about how cache can alter her expectations.

Notice: Undefined index: add_query_parameters in Drupal\menu_token\Service\MenuTokenContextManager->prepareContextualLinks() (line 67 of /var/www/centara/docroot/modules/contrib/menu_token/src/Service/MenuTokenContextManager.php)

Update #15 to be a patch.

Re-rolling from patch in #15

Patch from #21 could not be applied on current dev branch, neither it could not be at the time of posting it.
Added a patch that fixed that problem and also issue from #19.
Needs review.

Please re-roll for 9.1.x

Opened merge request:

• Re-rolls the patch for 9.1.x.
• Fixes a PHP warning that could occur when parsing the query string.
• Fixes the query string tokens not being added to the link when using Context to resolve the tokens.