As a followup to

#2764709: [Regression/Refactor] Restore Ajax link type "flag message" functionality

I think we should default to ajax link types where possible.

The field 'component' value is wrong ... it also relates to flag_follower.

CommentFileSizeAuthor
#2 2945797-2.patch986 bytesmartin107

Comments

martin107 created an issue. See original summary.

martin107’s picture

martin107 commented
Assigned: martin107 » Unassigned
StatusFileSize
new 2945797-2.patch986 bytes

Here is the patch... if you test the behaviour of flag_follower you will see something awkward looking
but those issues will be sorted out by

#2945772: Complete definition of flag follower

martin107’s picture

martin107 commented
Status: Active » Needs review
socketwench’s picture

socketwench commented
Status: Needs review » Reviewed & tested by the community

Sure. It was the default on D7. I'm somewhat concerned that would break some of the implicit testing we're using Follower and Bookmark for, but the tests themselves say otherwise.

  • martin107 authored 23b97b0 on 8.x-4.x 
    Issue #2945797 by martin107, socketwench: Update Flag follower and Flag...
socketwench’s picture

socketwench commented
Status: Reviewed & tested by the community » Fixed

Thanks Martin!

martin107’s picture

martin107 commented
Related issues: +#2945772: Complete definition of flag follower

I'm somewhat concerned that would break some of the implicit testing

That is a really good prediction.

It is kinda screwed up ...

a) flag_follower has lots of blank entries in the default entity.
b) In test when creating flags random string get inserted in place of blanks.

There is a little issue already to do tidy up when those 2 facts collide.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.