Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.As a followup to
#2764709: [Regression/Refactor] Restore Ajax link type "flag message" functionality
I think we should default to ajax link types where possible.
The field 'component' value is wrong ... it also relates to flag_follower.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 2945797-2.patch | 986 bytes | martin107 |
| |||
Comments
Comment #2
martin107 CreditAttribution: martin107 as a volunteer commentedHere is the patch... if you test the behaviour of flag_follower you will see something awkward looking
but those issues will be sorted out by
#2945772: Complete definition of flag follower
Comment #3
martin107 CreditAttribution: martin107 as a volunteer commentedComment #4
socketwench CreditAttribution: socketwench as a volunteer commentedSure. It was the default on D7. I'm somewhat concerned that would break some of the implicit testing we're using Follower and Bookmark for, but the tests themselves say otherwise.
Comment #6
socketwench CreditAttribution: socketwench as a volunteer commentedThanks Martin!
Comment #7
martin107 CreditAttribution: martin107 as a volunteer commentedThat is a really good prediction.
It is kinda screwed up ...
a) flag_follower has lots of blank entries in the default entity.
b) In test when creating flags random string get inserted in place of blanks.
There is a little issue already to do tidy up when those 2 facts collide.