Closed (fixed)
Project:
Drupal core
Version:
8.5.x-dev
Component:
javascript
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
8 Feb 2018 at 13:04 UTC
Updated:
8 Mar 2018 at 06:06 UTC
Jump to comment: Most recent
Comments
Comment #2
nod_It was a pleasure to have you on board! Thank you for all your help so far :)
Comment #3
GrandmaGlassesRopeMan@droplet Thanks so much for all of your outstanding help and wisdom. 😀
Comment #4
timmillwoodFrom a technical point of view, the patch looks fine. 😉
Comment #5
tedbow@droplet thanks for you help on the Settings Tray module's Javascript! It was good to work with you!
Comment #7
xjmThanks so much @droplet for all your contributions to our our JavaScript. Best wishes in your next projects!
Leaving RTBC against 8.5.x for backport after the commit freeze.
Comment #8
droplet commentedThanks @nod_
Thanks @drpal
Thanks @tedbow
and Thanks @timmillwood for the patch reviewing.
and @xjm to commit the patch.
Comment #9
xjmI have also added @droplet to https://www.drupal.org/core/maintainers/past. :)
Comment #10
jibranThanks, for your work. Added #2489834: Add droplet as maintainer for JavaScript as a blast from the past. ;)
Comment #11
justafishThank you for all your contributions droplet 🙏
Comment #12
dawehnerThank you @droplet. I learned a lot of edge cases of JS from you.
Comment #13
yoroy commentedThank you very much droplet and good luck!
Comment #14
lendude@droplet Thanks so much for all your instructions and insights!
Comment #16
catchThanks @droplet.
I've cherry-picked this to 8.5.x, so marking the issue fixed.
Comment #17
droplet commentedThanks ALL!
As a long-time volunteer, the open source contributor in Drupal Core, I'm officially leaving d.org now. 😭 In the future, if anybody like my work and funding me to any Core issues, I will be back very soon.
Comment #19
dmsmidtReading this in the release notes. Thanks again and good luck to you! You will be missed.