Link error "The internal path component is invalid" [#2943135]

Steps to reproduce

create an entity type that includes AJAX calls on the node edit form, e.g. node with a link field and a media field, or a field with multiple elements and "add another" links

as a user without the 'link to any page' permission, try to create an instance of that entity
enter an invalid path in the link field, e.g. 'foo'
click on the button that initiates an AJAX request, e.g. file upload, add another

Expected result

An error message should appear about the invalid internal path, but you should be able to proceed with the action

Actual result

It isn't possible to proceed.
The AJAX call responds with a 500 error "The internal path component is invalid. Its path component must have a leading slash" with field widget type "Link".

↵An AJAX HTTP error occurred.↵HTTP Result Code: 500↵Debugging information follows.↵Path: /fr/node/6/edit?element_parents=field_test/widget/0&destination=/admin/content&ajax_form=1↵StatusText: 500 Service unavailable (with message)↵ResponseText: The website encountered an unexpected error. Please try again later.InvalidArgumentException: The internal path component &#039;test&#039; is invalid. Its path component must have a leading slash, e.g. internal:/foo.

This error generates from \Drupal\Core\Url::fromInternalUri

It happens from \Drupal\link\Plugin\Field\FieldWidget\LinkWidget::formElement
in code
$item->getUrl()->access() (core/modules/link/src/Plugin/Field/FieldWidget/LinkWidget.php:175)

For avoidance of this error we have next element validator where check input values
\Drupal\link\Plugin\Field\FieldWidget\LinkWidget::validateUriElement

So we can't catch this error on common entity save operation.
But we can catch it with any additional ajax buttons, which skip validation with #limit_validation_errors

It appears on all browsers.

In my example "foo" value is incorrect for Link field. We can avoid this error by putting only correct values. But customer can be confused. He doesn't know what values are correct, and he doesn't know why all his AJAX buttons don't work. So we should avoid 500 error with ajax buttons.

I have investigated this issue and found, that we need to add additional check in \Drupal\link\Plugin\Field\FieldWidget\LinkWidget::formElement
I have prepared patch and I will apply it in comment.

Comment	File	Size	Author
#42	link_error_the_internal_path_component_is_invalid-2943135-041.patch	1.55 KB	stefan.korn
#40	link_error_the_internal_path_component_is_invalid-2943135-040.patch	1.53 KB	stefan.korn
#39	link_error_the_internal_path_component_is_invalid-2943135-039.patch	1.53 KB	stefan.korn
#37	link_error_the_internal_path_component_is_invalid-2943135-037.patch	1.48 KB	stefan.korn
#31	2943135-31.patch	7.19 KB	bgreco
#29	2943135-29.patch	6.18 KB	dhirendra.mishra
#28	drupal-link_ajax_error-2943135-28.patch	6.18 KB	siemen_hermans
#14	drupal-link_ajax_error-2943135-4.patch	5.83 KB	mangesh.borukar
#12	drupal-link_ajax_error-2943135-3.patch	5.83 KB	mangesh.borukar
#2	drupal-link_ajax_error-2943135-2.patch	5.85 KB	kalistos
#9	drupal-link_ajax_error-2943135-3.patch	6 KB	mangesh.borukar

Issue fork drupal-2943135

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

2943135-link-error-the compare
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

8 February 2018 at 07:44

kalistos created an issue. See original summary.

Comment #2

kalistos commented 8 February 2018 at 07:53

Status	File	Size
new	drupal-link_ajax_error-2943135-2.patch	5.85 KB

Comment #3

kalistos commented 8 February 2018 at 07:56

Status:

Active

» Needs review

Comment #4

8 February 2018 at 08:35

Status:

Needs review

» Needs work

The last submitted patch, 2: drupal-link_ajax_error-2943135-2.patch, failed testing. View results

Comment #5

andypost

he/him

Russian

commented 8 February 2018 at 21:11

Version:

8.4.x-dev

» 8.6.x-dev

Comment #6

zahord commented 14 February 2018 at 20:20

Hi, I was checking using 8.6.x and couldn't reproduce the issue using a link field and file field with ajax process

Comment #7

14 February 2018 at 20:20

Version:

8.6.x-dev

» 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #8

egruel commented 17 August 2018 at 09:27

Hi, I couldn't reproduce the issue usin wiht the admin user but i have reproduce this issue with a not admin user, and the patch fix the problem.

Comment #9

mangesh.borukar commented 17 October 2018 at 10:45

Status	File	Size
new	drupal-link_ajax_error-2943135-3.patch	6 KB

Above patch not working with Drupal 8.6.1, created a new patch to handle this issue.

Comment #10

mangesh.borukar commented 17 October 2018 at 14:05

Comment #11

mangesh.borukar commented 17 October 2018 at 14:05

1 file was hidden/shown/deleted

Status	File	Size
hidden	drupal-link_ajax_error-2943135-3.patch	6 KB

Comment #12

mangesh.borukar commented 17 October 2018 at 14:36

Status	File	Size
new	drupal-link_ajax_error-2943135-3.patch	5.83 KB

1 file was hidden/shown/deleted

Status	File	Size
shown	drupal-link_ajax_error-2943135-3.patch	6 KB

Comment #13

mangesh.borukar commented 17 October 2018 at 14:37

1 file was hidden/shown/deleted

Status	File	Size
hidden	drupal-link_ajax_error-2943135-3.patch	6 KB

Comment #14

mangesh.borukar commented 17 October 2018 at 14:45

Status	File	Size
new	drupal-link_ajax_error-2943135-4.patch	5.83 KB

Comment #15

mangesh.borukar commented 17 October 2018 at 14:45

1 file was hidden/shown/deleted

Status	File	Size
hidden	drupal-link_ajax_error-2943135-3.patch	5.83 KB

Comment #16

malcomio commented 18 October 2018 at 13:56

Issue summary:

View changes

Comment #17

malcomio commented 18 October 2018 at 15:37

As far as I can see from a quick test, the patch addresses the issue described, but it also seems to remove the URL validation - with the patch applied, I was able to create a link to a non-existent local path

Comment #18

malcomio commented 19 October 2018 at 11:01

Issue summary:

View changes

Comment #19

malcomio commented 19 October 2018 at 11:24

I haven't been able to reproduce this issue on a clean 8.6.x install.

However, the issue does exist on our project (which is built from an install profile with numerous contrib and custom modules enabled).

Need to clarify the steps to reproduce.

Comment #20

malcomio commented 19 October 2018 at 17:54

Issue summary:

View changes

Comment #21

malcomio commented 19 October 2018 at 17:58

siemen_hermans commented 13 July 2021 at 13:32

Status	File	Size
new	drupal-link_ajax_error-2943135-28.patch	6.18 KB

Providing a patch for Drupal 9.2.x

Comment #29

dhirendra.mishra commented 22 July 2021 at 05:57

Status:

Needs work

» Needs review

Status	File	Size
new	2943135-29.patch	6.18 KB

uploading against 9.3.x

Comment #30

22 July 2021 at 06:54

Status:

Needs review

» Needs work

The last submitted patch, 29: 2943135-29.patch, failed testing. View results

Comment #31

bgreco commented 1 December 2021 at 19:17

Status	File	Size
new	2943135-31.patch	7.19 KB

Modified the failing test so it passes with patch #29

Comment #32

bgreco commented 1 December 2021 at 19:19

Status:

Needs work

» Needs review

Comment #33

1 December 2021 at 19:19

Version:

9.3.x-dev

» 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #34

1 December 2021 at 19:19

Version:

9.4.x-dev

» 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #35

smustgrave commented 27 July 2022 at 16:50

Status:

Needs review

» Postponed (maintainer needs more info)

Tested this without the patch following the issue summary steps

Created a user without the "Link to any page" permission
Added a link field to a content type with unlimited setting
Logged in as said user
Created a node by adding foo into the url
Clicking Add another did not generate a 500 but just highlight the url field as error.

If you're still seeing the issue can you provide an updated issue summary and testing steps about where you are seeing it please.

Comment #36

27 July 2022 at 16:50

Version:

9.5.x-dev

» 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #37

stefan.korn

German

Jossgrund

commented 26 January 2023 at 16:05

Status:

Postponed (maintainer needs more info)

» Needs review

Status	File	Size
new	link_error_the_internal_path_component_is_invalid-2943135-037.patch	1.48 KB

So, maybe this issue can not be triggered directly via Drupal core, but there are cases where the issue occurs (see related issues).

and absolutely agree with #21

... a missing permission shouldn't cause a 500 error on an AJAX request.

Proposing a patch that roughly does the same as the previous patches but only operates in the LinkWidget class. not sure why the LinkAccessConstraintValidator class was touched in the previous patches. Does not seem necessary to fix the problem given in this issue.

Comment #38

26 January 2023 at 17:07

Status:

Needs review

» Needs work

The last submitted patch, 37: link_error_the_internal_path_component_is_invalid-2943135-037.patch, failed testing. View results

Comment #39

stefan.korn

German

Jossgrund

commented 26 January 2023 at 17:23

Status:

Needs work

» Needs review

Status	File	Size
new	link_error_the_internal_path_component_is_invalid-2943135-039.patch	1.53 KB

Comment #40

stefan.korn

German

Jossgrund

commented 26 January 2023 at 17:59

Status	File	Size
new	link_error_the_internal_path_component_is_invalid-2943135-040.patch	1.53 KB

Comment #41

26 January 2023 at 19:04

Status:

Needs review

» Needs work

The last submitted patch, 40: link_error_the_internal_path_component_is_invalid-2943135-040.patch, failed testing. View results

Comment #42

stefan.korn

German

Jossgrund

commented 27 January 2023 at 05:53

Status:

Needs work

» Needs review

Status	File	Size
new	link_error_the_internal_path_component_is_invalid-2943135-041.patch	1.55 KB

2 files were hidden/shown/deleted

Status	File	Size
hidden	link_error_the_internal_path_component_is_invalid-2943135-037.patch	1.48 KB
hidden	link_error_the_internal_path_component_is_invalid-2943135-039.patch	1.53 KB

Comment #43

Manoj Raj.R commented 27 January 2023 at 09:36

Comment #44

smustgrave commented 27 January 2023 at 17:32

Status:	Needs review	» Needs work
Issue tags:		+Needs tests

Tried retesting and still not seeing the error.

Tagging for tests as we will need a scenario that shows this issue.

Comment #45

27 January 2023 at 17:32

Version:

10.1.x-dev

» 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.