Closed (fixed)
Project:
Field Group Ajaxified Multipage
Version:
8.x-1.x-dev
Component:
Documentation
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
6 Feb 2018 at 17:14 UTC
Updated:
9 Mar 2018 at 07:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
volkswagenchicki have uploaded a patch that corrects some minor mistakes and converted the file to .md to utilize markdown.
Comment #3
volkswagenchickComment #4
jqtnguyen commentedAttempted to apply patch on simplytest.me, but encountered an error which is likely on simplytest.me's side.
I found some other minor typos as well, and also have a few grammatical suggestions.
Capitalize "Ajax" for consistency.
Suggestion to add a comma after "By using a Field Group".
Suggestion to add a period after "multipage form" and start a new sentence with "However".
Suggestion to end sentence with "basic" and begin new sentence with "Real validation".
Suggestion to re-word "often users will" to "users will often".
Capitalize "Ajaxified" for consistency, and suggestion to add a comma afterward.
Suggestion to add comma after "it", which will also result in a number of the following lines to need editing as well in order to stay within the 80 character per line limit.
Suggestion to rephrase as "can become considerably heavy to load since it uses javascript to hide/show related fields on each page, but the whole form is still loaded."
Typographical error. This should be "its", not "it's".
Comment #5
volkswagenchickThanks for the review. I am going to re-assign myself to the issue and patch again tomorrow. Sumplytest.me appears to be broken, hopefully that will be remedied by then.
Comment #6
volkswagenchickI addressed all of the concerns in comment #4 and uploaded a new patch. Simplytest.me was still not working when I uploaded this patch.
Comment #7
jqtnguyen commentedI was able to apply the Patch, but unable to get the Module working using the instructions in the README.
It's very unclear what to do at this step for someone unfamiliar with the module or multipage.
Comment #8
volkswagenchickComment #9
eduardo morales albertiI checked the patches and I created mine.
The readme was a copy of drupal 7 version. It is now adapted to what is currently available.
Please review it and if it's right or there are better changes please tell me.
Thank you.
Comment #10
omarlopesinoSeems good the new README for 8.x. Great!
Just this correction in line 47:
->
Comment #12
eduardo morales albertiOkey, I applied your changes.
Thank you.
Comment #13
eduardo morales albertiComment #14
volkswagenchickThankyou for all the work you do!!
I am encouraging team mates to help out on Drupal.org, could you go back and give JQTNguyen a credit for his RTBC?? The box next to his name just gets ticked and he gets a credit! I see it as a way of incentive to help get involved it the community! It takes a village.
Cheers!
AmyJune - volkswagenchick
Comment #15
eduardo morales albertiComment #16
eduardo morales albertiOkey volkswagenchick,
I already acredited in this issue to JQTNguyen