This is a follow up issue to #2938185: When installing Umami, only show warning if 'Demo Umami' radio button is selected (and ensure that it is obvious that warning message only applies to the Umami profile)

Let's make the installer as accessible as possible.

(Update: andrewmacpherson 11th September 2018):
I do still have some ideas to improve this. Quick brain dump follows...

Currently: The warning is nested inside the #description as a span, which uses the states system to control visibility (which results in display:none).
Problem: it isn't used in the accessible display description reliably. It seems that updating form descriptions dynamically, the new message doesn't get properly conveyed to assistive tech.
Ideas:
1. use visually-hidden on the span nested inside the #description. (Does the States API have that?) Then the waring would be part of the accessible description computation at all times, regardless of visibility.
2. If states API can't do it, can we use a selector in the stylesheet to do put equivalent styles on it?
2a: using the :checked pseudo class, to control visibility of the nested span
2b: using :focus-within on the .form-item wrapper div
3. A custom JS behaviour for the installer form could toggle the visually-hidden class instead.
4. another idea would be to take it out of the #description, and give it an ID of it's own. Then fudge the form so the Umami radio was aria-describedby two elements. States API (display:none) wouldn't be a problem then, because aria-describedby can work with display:none, if it is on the same element with the targeted ID ref. The reason it doesn't work at the moment is that the description ID and display:none are on different elements.

Background, things we already tried:
We tried various arrangements of aria live roles. The results were very flaky, some screen readers announced it immediately, some didn't. In some cases the warning it couldn't be found at all. Eventually we went for States API, and said we'd do accessibility in a follow-up. It's still worth fixing, but it's fallen down my priority list.
We didn't try all of my suggestions before finishing the other issue (it was a bit big, and screen readers were only one aspect, so I agreed to address it in a follow-up. That's good, because it's going to be easier to test on it's own, without other stuff happening in the same patch.
My old testing notes may no longer apply, I need to do a new round of that. The previous solutions and testing notes are probably hard to understand unless you have knowledge of different screen readers, and ARIA implementations. The flakiness was rooted deep in the way aria-live works. Other approaches involved a exploiting a (spec-compliant) quirk of the way that aria-describedby works, but were hard. So we went for a simple use of States API.

Comments

markconroy created an issue. See original summary.

andrewmacpherson’s picture

Category: Feature request » Bug report
Issue tags: +Accessibility
cehfisher’s picture

Are there tasks for this ticket @andrewmacpherson? Or more of a placeholder to focus on accessibility in general?

markconroy’s picture

Issue tags: +dclondon

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

eli-t’s picture

Status: Active » Closed (won't fix)

Closing as not actionable without further instruction. This is a follow up to #2938185 but that has 77 comments and this points to no specific part. Can be reopened if more concrete aspirations are outlined.

andrewmacpherson’s picture

Issue summary: View changes
Status: Closed (won't fix) » Active
Issue tags: +Needs issue summary update

Leave this open please, it's still worth fixing. The remaining issue is with the warning message that appears visually when the Umami Demo radio button is selected. The message is very unreliable for screen readers at present

We didn't try all of my suggestions before finishing the other issue (it was a bit big, and screen readers were only one aspect, so I agreed to address it in a follow-up). That's OKAY, because it's going to be easier to test on it's own, without other stuff happening in the same patch.

I've added a messy brain dump to the issue summary. This has been kicking around in my head for a while, never wrote it down.

eli-t’s picture

@andrewmacpherson++ thanks for the update!

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

larowlan’s picture

Is this a bug or a task?

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

mgifford’s picture

Issue tags: +wcag412

This sounds like an 4.1.2 issue from the description. The name is hidden from the screen reader.

lauriii’s picture

Status: Active » Closed (outdated)

The warning has been removed in #2938803: Remove the warning about the Umami profile on the install screen so I believe this is outdated now.