We ran phpcs but didn't catch as much as we could.

It's the start of a new release so trying to get this in quickly for all the rerolls that this will cause.

CommentFileSizeAuthor
#4 2942012-4.patch262.51 KBjoelpittet
#2 2942012-2.patch260.27 KBjoelpittet

Comments

joelpittet created an issue. See original summary.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new 2942012-2.patch260.27 KB
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Easier to review with: git diff -w --color-words

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new 2942012-4.patch262.51 KB

Status: Needs review » Needs work

The last submitted patch, 4: 2942012-4.patch, failed testing. View results

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs work » Needs review

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Fixed

Pushed to -dev

cyb_tachyon’s picture

cyb_tachyon commented

Just noting there that this was reviewed at PNWDS 2018. :thumbsup:

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.