[D8] CSV Importer

Please add some instructions in ReadMe.txt

Review of the 8.x-1.x branch (commit 880ad47):

• Your README.txt does not follow best practices. See https://www.drupal.org/node/2181737 .
• Your module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .

PAReview has found some issues with your latest commit. See https://pareview.cc/pareview/https-git.drupal.org-project-csv_importer.g...

You can also repeat the review yourself after you pushed new changes.

Review of the 8.x-1.x branch (commit b06b84a):

• Your README.md does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
  • The INTRODUCTION section is missing.
  • The REQUIREMENTS section is missing.
  • The INSTALLATION section is missing.
  • The CONFIGURATION section is missing.
• Bad line endings were found, always use unix style terminators. See https://www.drupal.org/coding-standards#indenting
  

  ./tests/modules/csv_importer_test/content/csv_example_node_test.csv:                                                               ASCII text, with very long lines, with CRLF line terminators
  ./tests/modules/csv_importer_test/content/csv_example_taxonomy_term_test.csv:                                                      ASCII text, with very long lines, with CRLF line terminators
  ./tests/modules/csv_importer_test/content/csv_example_user_test.csv:                                                               ASCII text, with very long lines, with CRLF line terminators
  tests/modules/csv_importer_test/content/csv_example_node_test.csv
  tests/modules/csv_importer_test/content/csv_example_taxonomy_term_test.csv
  tests/modules/csv_importer_test/content/csv_example_user_test.csv
  

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...e1101/web/vendor/drupal/pareviewsh/pareview_temp/csv_importer.module
--------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
 20 | ERROR | [x] Expected 1 space after ".="; 0 found
 22 | ERROR | [x] Concat operator must be surrounded by a single space
 28 | ERROR | [x] Expected 1 space after ".="; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.md
--------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------
  3 | WARNING | [ ] Line exceeds 80 characters; contains 136 characters
 19 | ERROR   | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 951ms; Memory: 6Mb

Hi @lashabp,

I have checked the coding standards using Coder Sniffer, no issues found.

Thankyou.

Hi lashabp,

Although the import works fine, I still get php warnings and fatal errors. Please fix those.

Thanks

Thank you for your contribution!
I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.