Closed (fixed)
Project:
Drupal core
Version:
8.5.x-dev
Component:
phpunit
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
30 Jan 2018 at 16:24 UTC
Updated:
6 Jun 2018 at 03:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
neclimdulPatch
Comment #3
neclimdulSuccess, one fewer reported test.
Comment #4
neclimdulComment #5
alena_stanul commentedYou changed name of function testProvider() with description 'The test data provider.'. In my opinion, the description should also be made more clear.
Comment #6
neclimdulsure, I was limiting the scope to fixing the method names but we might as well fix the doc too. do you want to roll the patch?
Comment #7
alena_stanul commentedI will change to roll patch:
- for testTransform() description from 'The test data provider.' to 'Tests transformation of filter_id plugin.' ;
- for provideFilters() from 'The test data provider.' to 'The test of filter provider.'
Comment #8
alena_stanul commentedWere changed descriptions in accordance with the new names of the methods of the class.
Comment #9
borisson_This doesn't make it any better I think. I'd prefer something like:
Provides test filter for ::testTransform.Or doesn't that make it better?
Comment #10
alena_stanul commented@borisson_ Thanks for your comment. Yes I agree with you to change description for method provideFilters() to 'Provides test filter for ::testTransform.' I Re-rolled the patch.
Comment #11
borisson_This looks solid!
PS: Next time, please provide an interdiff as well as a patch to make reviewing easier.
Comment #13
MixologicTemporary testbot hiccup.
Comment #14
neclimdulI don't think this is ready actually. Also, getting documentation right is hard which is one reason I didn't include it in the original patch. :-D
1) I'm going to push back on the ::testTransform part. Its kind of an anti-pattern in my opinion and doesn't really help anything. It does add maintenance headaches though. Do we document any other method that adds it in the future? What if the method name changes again?
2) The dataset is plural. "filters" not "filter"
3) If we're fixing the documentation, we should be more clear about the structure of the provided dataset.
Something more like:
This kinda exposes a failing of the design of this test that the dataset structure is tightly coupled to the logic and code of the test though
$invalid_idbut we really do need to control some scope here and move forward with getting something fixed. ;)Comment #15
borisson_Fixed #14.
Comment #16
borisson_I don't think I can move this back to RTBC because I also added a patch. I just noticed that this issue was novice, sorry about that.
Comment #17
neclimdulyeah, that's mostly on me for doing the review. Sorry been busy and missed the update.
Comment #19
neclimdulrandom failure: #2973992: Permission issue in Nightwatch step marks all full testruns as unstable
Comment #21
neclimdulThere are no failed results. I don't know what testbot was upset about but going to reset it again... :-/
Comment #24
larowlanCommitted as 69167b5 and pushed to 8.6.x.
Cherry-picked as 75c8cdd and pushed to 8.5.x.
Can we get a follow up (novice) to add names to the test cases?
e.g from
to
The output from phpunit is much easier to understand.
Test case 'Filter ID mapped to plugin that exists' being better than Test case '0'
Comment #25
neclimdulThanks!
Follow up: #2974657: Improve FilterIdTest provider keys