Test code for \Drupal\Tests\feeds\Unit\Feeds\Target\FileTest is commented out. Let's try to repair this test.

CommentFileSizeAuthor
#12 interdiff-2940280-10-12.txt6.06 KBmegachriz
#12 feeds-file-target-test-2940280-12.patch12.81 KBmegachriz
#10 feeds-file-target-test-2940280-10.patch10.47 KBmegachriz
#6 interdiff-2940280-4-6.txt4.15 KBmegachriz
#6 feeds-file-target-test-2940280-6.patch5.45 KBmegachriz
#4 interdiff-2940280-2-4.txt699 bytesmegachriz
#4 feeds-file-target-test-2940280-4.patch3.4 KBmegachriz
#2 feeds-file-target-test-2940280-2.patch3.41 KBmegachriz

Comments

MegaChriz created an issue. See original summary.

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Active » Needs review
StatusFileSize
new feeds-file-target-test-2940280-2.patch3.41 KB

Status: Needs review » Needs work

The last submitted patch, 2: feeds-file-target-test-2940280-2.patch, failed testing. View results

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs work » Needs review
StatusFileSize
new feeds-file-target-test-2940280-4.patch3.4 KB
new interdiff-2940280-2-4.txt699 bytes

Status: Needs review » Needs work

The last submitted patch, 4: feeds-file-target-test-2940280-4.patch, failed testing. View results

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs work » Needs review
StatusFileSize
new feeds-file-target-test-2940280-6.patch5.45 KB
new interdiff-2940280-4-6.txt4.15 KB

Note: test coverage for subtarget 'target_id' is missing.

  • MegaChriz committed 7fd8c59 on 8.x-3.x 
    Issue #2940280 by MegaChriz: Added some test coverage for the file...
megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs review » Active

Committed #6. Leaving issue open for adding coverage for subtarget 'target_id'.

  • MegaChriz committed 7b0e051 on 8.x-3.x 
    by MegaChriz: added assets for issues #2772595 and #2940280.
megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Active » Needs review
StatusFileSize
new feeds-file-target-test-2940280-10.patch10.47 KB

This test tries to cover the following cases:

  1. Setting file description.
  2. Downloading file with success.
  3. File not found.
  4. File with an invalid extension.

Ironically, locally this test is failing on an error reported in #2951965: PHP 5.6: Fatal error during import: FormattableMarkup::__toString() must not throw an exception!

Status: Needs review » Needs work

The last submitted patch, 10: feeds-file-target-test-2940280-10.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs work » Needs review
StatusFileSize
new feeds-file-target-test-2940280-12.patch12.81 KB
new interdiff-2940280-10-12.txt6.06 KB

  • MegaChriz committed 8d3945e on 8.x-3.x 
    Issue #2940280 by MegaChriz: Added test coverage for the file target's '...
megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs review » Fixed

Committed #12 with a few differences: removed @group test from methods. Test coverage for providing an empty value for 'target_id' will go into #2772595: When mapping to File or Image fields, empty source for target_id causes Exception and breaks import process., as there are some issues with that.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.