Add test coverage for the file target. [#2940280]

Test code for \Drupal\Tests\feeds\Unit\Feeds\Target\FileTest is commented out. Let's try to repair this test.

Comment	File	Size	Author
#12	interdiff-2940280-10-12.txt	6.06 KB	MegaChriz
#12	feeds-file-target-test-2940280-12.patch	12.81 KB	MegaChriz
#12	8.x-3.x: PHP 5.5 & MySQL 5.5, D8.5 255 pass
#10	feeds-file-target-test-2940280-10.patch	10.47 KB	MegaChriz
#10	8.x-3.x: PHP 5.5 & MySQL 5.5, D8.5 251 pass, 2 fail
#6	interdiff-2940280-4-6.txt	4.15 KB	MegaChriz
#6	feeds-file-target-test-2940280-6.patch	5.45 KB	MegaChriz
#6	8.x-3.x: PHP 5.5 & MySQL 5.5, D8.5 166 pass
#4	interdiff-2940280-2-4.txt	699 bytes	MegaChriz
#4	feeds-file-target-test-2940280-4.patch	3.4 KB	MegaChriz
#4	8.x-3.x: PHP 5.5 & MySQL 5.5, D8.5 165 pass, 2 fail
#2	feeds-file-target-test-2940280-2.patch	3.41 KB	MegaChriz
#2	8.x-3.x: PHP 5.5 & MySQL 5.5, D8.5 165 pass, 2 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

29 January 2018 at 11:32

MegaChriz created an issue. See original summary.

Comment #2

MegaChriz CreditAttribution: MegaChriz at WebCoo commented 29 January 2018 at 11:33

Status:

Active

» Needs review

File	Size
feeds-file-target-test-2940280-2.patch	3.41 KB
8.x-3.x: PHP 5.5 & MySQL 5.5, D8.5 165 pass, 2 fail

Comment #3

29 January 2018 at 11:36

Status:

Needs review

» Needs work

The last submitted patch, 2: feeds-file-target-test-2940280-2.patch, failed testing. View results

Comment #4

MegaChriz CreditAttribution: MegaChriz at WebCoo commented 29 January 2018 at 11:43

Status:

Needs work

» Needs review

File	Size
feeds-file-target-test-2940280-4.patch	3.4 KB
8.x-3.x: PHP 5.5 & MySQL 5.5, D8.5 165 pass, 2 fail
interdiff-2940280-2-4.txt	699 bytes

Comment #5

29 January 2018 at 11:48

Status:

Needs review

» Needs work

The last submitted patch, 4: feeds-file-target-test-2940280-4.patch, failed testing. View results

Comment #6

MegaChriz CreditAttribution: MegaChriz at WebCoo commented 29 January 2018 at 13:41

Status:

Needs work

» Needs review

File	Size
feeds-file-target-test-2940280-6.patch	5.45 KB
8.x-3.x: PHP 5.5 & MySQL 5.5, D8.5 166 pass
interdiff-2940280-4-6.txt	4.15 KB

Note: test coverage for subtarget 'target_id' is missing.

Comment #7

29 January 2018 at 14:07

MegaChriz committed 7fd8c59 on 8.x-3.x

Issue #2940280 by MegaChriz: Added some test coverage for the file...

Comment #8

MegaChriz CreditAttribution: MegaChriz at WebCoo commented 29 January 2018 at 14:07

Status:

Needs review

» Active

Committed #6. Leaving issue open for adding coverage for subtarget 'target_id'.

Comment #9

3 May 2018 at 11:34

MegaChriz committed 7b0e051 on 8.x-3.x

by MegaChriz: added assets for issues #2772595 and #2940280.

Comment #10

MegaChriz CreditAttribution: MegaChriz as a volunteer commented 3 May 2018 at 13:57

Status:

Active

» Needs review

File	Size
feeds-file-target-test-2940280-10.patch	10.47 KB
8.x-3.x: PHP 5.5 & MySQL 5.5, D8.5 251 pass, 2 fail

This test tries to cover the following cases:

Setting file description.
Downloading file with success.
File not found.
File with an invalid extension.

Ironically, locally this test is failing on an error reported in #2951965: PHP 5.6: Fatal error during import: FormattableMarkup::__toString() must not throw an exception!

Comment #11

3 May 2018 at 14:04

Status:

Needs review

» Needs work

The last submitted patch, 10: feeds-file-target-test-2940280-10.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Comment #12

MegaChriz CreditAttribution: MegaChriz as a volunteer commented 3 May 2018 at 15:46

Status:

Needs work

» Needs review

File	Size
feeds-file-target-test-2940280-12.patch	12.81 KB
8.x-3.x: PHP 5.5 & MySQL 5.5, D8.5 255 pass
interdiff-2940280-10-12.txt	6.06 KB

Comment #13

3 May 2018 at 19:11

MegaChriz committed 8d3945e on 8.x-3.x

Issue #2940280 by MegaChriz: Added test coverage for the file target's '...

Comment #14

MegaChriz CreditAttribution: MegaChriz as a volunteer commented 3 May 2018 at 19:11

Status:

Needs review

» Fixed

Committed #12 with a few differences: removed @group test from methods. Test coverage for providing an empty value for 'target_id' will go into #2772595: When mapping to File or Image fields, empty source for target_id causes Exception and breaks import process., as there are some issues with that.