Currently the module displays radio buttons on what is to be included in the index like this:
○ All except those selected
● None except those selected
Which is actually strange, at least to me, because of the double negative (none except).
The attached patch changes this to a more sensible wording, and I dare a more sensible order of these options:
● Only those selected
○ All except those selected
Check attached screenshot too.
| Comment | File | Size | Author |
|---|---|---|---|
| search_api_better_inclusion_text.patch | 1.21 KB | bserem | |
| search_api_better_ui_text.png | 69.44 KB | bserem |
Comments
Comment #2
bserem commentedComment #3
drunken monkeyHm, you're right, that probably does make more sense. Might just be confusing to people who are already used to the current layout – especially if we also change the order.
Also, I'm (as you can see from the Search API UI) no UI/UX expert, so it would be great to get input here from one to make sure this is actually an improvement. Do you maybe know someone you can point to this issue? (I've already advertized in #2471184: Suggestions for improving the Search API admin UI for the Add/Edit Index screen, maybe that will be enough anyways.)
Comment #4
bserem commentedWell, I can share this with the rest of my team in the current D8 search api project and see what they say, but in general the double negative doesn't really help.
The order could stay as is I guess.
Comment #5
borisson_I like this! Like @drunken monkey said, I'm not sure about changing the order of the items, but I don't think it matters much, this does read better.
I've asked in #ux on drupalslack to see if someone would like to give input on this issue.
Comment #6
yoroy commentedThat's a sensible change. I do think changing the order is a relevant improvement as well.
Comment #7
borisson_Going to RTBC this, based on the feedback of @yoroy, thanks!
Comment #8
bserem commentedGreat! Thanks
Comment #10
drunken monkeyOK, then, thanks for both your reviews! Then I guess there can be little doubt this is indeed a worthwhile change.
So: committed.
Thanks again, bserem!