Unable to uninstall [#2939095]

Comment	File	Size	Author
#17	unable_to_uninstall_backup_migrate-2939095-17.patch	427 bytes	karuna patel
#13	backup_migrate-n2939095-13.patch	3.6 KB	damienmckenna

Comment #1

24 January 2018 at 10:28

roborew created an issue. See original summary.

Log in or register to post comments

Comment #2

ioana apetri commented 24 January 2018 at 10:50

I've tested on Drupal 8.5 and it works perfectly for me.

Log in or register to post comments

Comment #3

damienmckenna

TN, USA

commented 24 January 2018 at 13:43

I'm sorry you've ran into this bug. Had you created any custom configurations (extra destinations, sources, schedule)?

Log in or register to post comments

Comment #4

roborew commented 24 January 2018 at 14:58

Actually likely I have, ill try clearing all configuration and attempt uninstalling again. Will report back.

Log in or register to post comments

Comment #5

ikit-claw commented 24 January 2018 at 16:25

Did you install with Composer and then try to uninstall with Drush?

Log in or register to post comments

Comment #6

roborew commented 25 January 2018 at 15:24

I installed the package with composer. Enabled with Drush and committed the config.

Just removed all configuration through the UI and tried uninstalling again using both Drush and through UI and still receiving the error unfortunately.

I might try a ditch attempt and see what happens if I edit the config directly and import to see if this uninstalls the module.

Log in or register to post comments

Comment #7

roborew commented 25 January 2018 at 15:41

Removed backup_migrate from core.extension and removed all config files.

Drush cim still results in the same error.

Not critical for now as we are not using the module but has no impact on production, but not got any time yet to debug. If anyone else has run into this and has a solution it would be appreciated.

Log in or register to post comments

Comment #8

yazzbe commented 25 January 2018 at 21:13

My error log complained about a private files folder that could not be found by the module.

Warning: opendir(): Unable to find the wrapper "private" - did you forget to enable it when you configured PHP? in BackupMigrate\Core\Destination\DirectoryDestination->_getAllFileNames() (line 245 of /sites/web/mydrupal/www/modules/backup_migrate/lib/backup_migrate_core/src/Destination/DirectoryDestination.php)

Created a private files folder (files/private).
hit save on the configuration > media > file system to set the .htaccess
run update.php, run cron, cleared cache & checked status report for errors.

After that. I was able to uninstalled the module (with drush).

Log in or register to post comments

Comment #9

tandroid commented 14 February 2018 at 22:54

I wasn't able to track down the real issue, but if anyone is looking for a quick and dirty solution to getting this uninstalled, you can add the route to the backup_migrate.routing.yml file so it won't throw an error. This is what I added:

entity.backup_migrate_source.canonical:
  path: '/admin/config/development/backup_migrate/remove'

Log in or register to post comments

Comment #10

damienmckenna

TN, USA

commented 21 February 2018 at 13:22

Version:

8.x-4.0-beta3

» 8.x-4.x-dev

Log in or register to post comments

Comment #11

bradjones1

English

commented 31 March 2018 at 01:13

I ran into this ticket while debugging the failed uninstall of one of my custom modules; the issue here is that the Source entity type specifies a canonical link template, however there is no corresponding route. So a quick patch to remove that link template should fix this.

Log in or register to post comments

Comment #12

purencool commented 1 April 2018 at 02:46

@tandroid #9 worked fine for me thanks

Log in or register to post comments

Comment #13

damienmckenna

TN, USA

commented 1 April 2018 at 22:59

Status:

Active

» Needs review

Status	File	Size
new	backup_migrate-n2939095-13.patch	3.6 KB

Out of interest, does this fix the problem? I noticed there was a difference between the routes the entity defined vs what the routing file had.

This patch tries to match them all up as they currently are.

While reviewing them I noticed that some of them were structured differently. Most of them are in the format /admin/config/development/backup_migrate/[entity]/[action]/[entity_id] though some are /admin/config/development/backup_migrate/[entity]/[entity_id]/[action]. I think we could do a follow-on issue to resolve these inconsistencies, but for now hopefully this will help.

Log in or register to post comments

Comment #14

1 April 2018 at 23:08

Status:

Needs review

» Needs work

The last submitted patch, 13: backup_migrate-n2939095-13.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Log in or register to post comments

Comment #15

s_leu commented 15 May 2018 at 04:45

The patch in the last post didn't fix the problem for me. Also it introduces more problems, after applying and trying to uninstall backup_migrate using drush, i get

[Syntax Error] Expected Doctrine\Common\Annotations\DocLexer::T_CLOSE_CURLY_BRACES, got 'canonical' at position 678 in class Drupal\backup_migrate\Entity\SettingsProfile.