When a node is shown in the book module then the "Add comment" link is displayed at the bottom of the node. This is unnecessary when comments already exist because then the comment form with "add comment" field and button is already shown on the page.
The Bartik theme seems to fix this with the following snippet. We should probably implement this in socialbase as well.
/**
* Implements hook_preprocess_HOOK() for node.html.twig.
*/
function bartik_preprocess_node(&$variables) {
// Remove the "Add new comment" link on teasers or when the comment form is
// displayed on the page.
if ($variables['teaser'] || !empty($variables['content']['comments']['comment_form'])) {
unset($variables['content']['links']['comment']['#links']['comment-add']);
}
}
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | book-teaser-comment.png | 191.06 KB | left |
| #13 | book-node-comment.png | 89.39 KB | left |
| #6 | open-social-book-module-shows-add-comment-link-when-comment-form-is-displayed-2938566-6.patch | 630 bytes | rajesh kairamkonda |
Comments
Comment #2
Evelienschut commentedBtw from the customer: removing the ADD NEW COMMENT link makes the most sense.
Comment #3
brhane commentedComment #4
ronaldtebrake commentedComment #5
ritzz commentedComment #6
rajesh kairamkonda commentedRemoved the "ADD NEW COMMENT" link
Comment #7
rajesh kairamkonda commentedComment #8
ritzz commentedComment #9
kingdutchI'm going to mark this as needs work for a few reasons. I've not done any manual testing but only done patch review.
Comment #10
shubham_narlawar commentedComment #11
kingdutchFrom the instructions beneath the "Issue tags" field. Please
Comment #12
leftComment #13
leftI see two things happening and I am note sure which is relevant. Maybe both.
1. When on the full node, and there is a comment already on the page, we see a "Add new comment" button. I think this serves to take us to the comment form. It's inconsistent with other content types, as far as I can see.
2. On the teasers, we see a comment count in text, and we see an "Add comment" button. This is inconsistent with the other teaser
Is it correct that in both cases, we don't want the "Add new comment" button to appear?
And that the comment count should be removed from the teaser (in favour of the icon comment count)?
Comment #14
leftI attempted to implement the snippet from Bartik and didn't get results. I changed the template to Bartik and the Book node pages were not affected. I am not sure why this is. A second opinion would be good.
So, I have two proposed solutions - both are incomplete
1. In the Link preprocess class, I can remove all add-comment and comment-comments (code in currently commented out)
This would affect all nodes.
https://github.com/goalgorilla/open_social/pull/796/files#diff-204941b91...
2. In the Node preprocess I can unset links for Book teasers. This means I need to manually add a read more button to the template.This is not done yet
https://github.com/goalgorilla/open_social/pull/796/files#diff-c0c92d787...
PR is here https://github.com/goalgorilla/open_social/pull/796
Input welcome.
Comment #15
leftI have opted for option 1.
1. In the Link preprocess class, I can remove all add-comment and comment-comments (code in currently commented out)
This would affect all nodes.
PR is waiting for review.
https://github.com/goalgorilla/open_social/pull/796
Comment #16
jaapjan commentedThank you all, just merged the pull request!