Problem/Motivation

Using the standard install, the Comment field on articles is set to required, which results in the red asterisk appearing on the node edit form. This is fairly distracting when viewing the form, and since it only applies to the open/closed setting, it is not relevant at all as the field has a default. So I believe this is by mistake.

Proposed resolution

Update the install config so that this field is not required.

User interface changes

Removes the red asterisk from the field.

Before:

After:

CommentFileSizeAuthor
#13 Screen Shot 2018-01-23 at 3.35.17 PM.png23.53 KBpameeela
#5 Before_Varnish.png72.4 KBriddhi.addweb
#5 After_Varnish.png71.24 KBriddhi.addweb
#2 comment-required-2937980-2.patch518 bytespameeela
Screen Shot 2018-01-19 at 9.35.07 PM.png59.06 KBpameeela
Screen Shot 2018-01-19 at 9.28.18 PM.png71.94 KBpameeela

Comments

pameeela created an issue. See original summary.

pameeela’s picture

pameeela commented
StatusFileSize
new comment-required-2937980-2.patch518 bytes

Here's a patch that fixes it... not sure whether this is correct though!

cilefen’s picture

cilefen commented
Status: Active » Needs review
riddhi.addweb’s picture

riddhi.addweb commented
Status: Needs review » Reviewed & tested by the community

@pameeela, Thanks for the patch your patch works, exactly as described in above summary. I checked your Patch using simplytest.me & also attached the screenshots for the same.

riddhi.addweb’s picture

riddhi.addweb commented
StatusFileSize
new After_Varnish.png71.24 KB
new Before_Varnish.png72.4 KB

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: comment-required-2937980-2.patch, failed testing. View results

cilefen’s picture

cilefen commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: comment-required-2937980-2.patch, failed testing. View results

pameeela’s picture

pameeela commented
Status: Needs work » Needs review

Trying one more time...

pameeela’s picture

pameeela commented

Anyone know what's wrong here? Seems unlikely this change has caused any actual fails?

pameeela’s picture

pameeela commented
Status: Needs review » Reviewed & tested by the community

I'm told by @larowlan these are unrelated fails so going back to RTBC.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Needs review

Can we get a screenshot of how this looks with the field expanded when the form is originally loaded?

default_value:
  -
    status: 2
    cid: 0
    last_comment_name: null
    last_comment_timestamp: 0
    last_comment_uid: 0

Should be defaulting to 2 which is 'Open'

pameeela’s picture

pameeela commented
Issue summary: View changes
StatusFileSize
new Screen Shot 2018-01-23 at 3.35.17 PM.png23.53 KB

Here's a screenshot of it expanded, but it isn't expanded by default. The original screenshots show the default state when the form is loaded.

pameeela’s picture

pameeela commented

Sorry, per Slack I understand now :) You meant "Open" as the status for Comments.

pameeela’s picture

pameeela commented
Status: Needs review » Reviewed & tested by the community

  • larowlan committed f69af23 on 8.6.x 
    Issue #2937980 by pameeela, Jigar.addweb: Standard install sets article...

  • larowlan committed cc8c7a8 on 8.5.x 
    Issue #2937980 by pameeela, Jigar.addweb: Standard install sets article...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Version: 8.6.x-dev » 8.5.x-dev
Status: Reviewed & tested by the community » Fixed

Committed as f69af23 and pushed to 8.6.x

Cherry-picked as cc8c7a8 and pushed to 8.5.x

I had originally thought that there may be a REST impact here, and that making sure the underlying data model required the field may be a factor.

However, the field is configurable and can be marked as not-required by an admin without any impact on the data model, as there is a default value configured for the field. This was demonstrated by @pameeela in #13. In addition REST deals with the lower-level field-type and not a specific field in the standard profile.

Thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.