General migration issues from D6 ubercart with multiple languages

Actually, having said that, when disabling commerce_migrate and sub-module. I still get a lot of errors, it might not be a commerce_migrate issue...

[error] Attempt to create a field field_group_frontpage that does not exist on entity type node. (/home/william/willserv/am.es/web/core/modules/field/src/Entity/FieldConfig.php:293)
[error] Attempt to create a field field_group_frontpage that does not exist on entity type node. (/home/william/willserv/am.es/web/core/modules/field/src/Entity/FieldConfig.php:293)
[status] Processed 58 items (0 created, 0 updated, 25 failed, 33 ignored) - done with 'upgrade_d6_field_instance'
[error] upgrade_d6_field_instance Migration - 25 failed.
[status] Processed 6 items (6 created, 0 updated, 0 failed, 0 ignored) - done with 'upgrade_d6_view_modes'
[error] Missing bundle entity, entity type node_type, entity id frontpage_slideshow. (/home/william/willserv/am.es/web/core/lib/Drupal/Core/Entity/EntityType.php:883)
[error] Missing bundle entity, entity type node_type, entity id affiliate. (/home/william/willserv/am.es/web/core/lib/Drupal/Core/Entity/EntityType.php:883)
[error] Missing bundle entity, entity type node_type, entity id product_information. (/home/william/willserv/am.es/web/core/lib/Drupal/Core/Entity/EntityType.php:883)
[error] Missing bundle entity, entity type node_type, entity id affiliate. (/home/william/willserv/am.es/web/core/lib/Drupal/Core/Entity/EntityType.php:883)

Another issue I have...
upgrade_d6_node_product fails here:
web/modules/contrib/commerce/modules/product/src/Entity/Product.php, line 285
Call to a member function isEmpty() on null

This is because, for some reason, $variation is just an id number, it is not a loaded object, therefore $variation->product_id->isEmpty cannot be applied.
In $this->variations I see this:
$this
values
[variations] Array
[target_id] 989

Hi @quietone,
sorry for the delay in getting back to you, I'm not getting email updates as I should...

I need to get back to you about most of the above, however for:

3) Dependencies
This patch did fix the error but it caused the same migrations to be repeated many many times. I think certain top level migrations (like user) must have been called about 100 times. However all this did really was loop through all dependencies for all migrations, it didn't fix the root of the issue which is that migrate plus/tools is not adding the upgrade prefix to some of the migrations, nor is it included in the migration group I created, therefore I have to use this --execute-dependencies parameter otherwise some key migrations don't get run.

4) Field groups?
It is from the field group module. However I could have sworn that this had been working fine previously. Will look into that point.

In general, I checked the dblog after migration and there were no errors committed to log, not any migration errors anyway. Several migrations say they have failed but don't report why, I might need to debug them.

Great! I didn't know about these messages.

Response to point 1).

I get this error from d6_field_formatter_settings:

source_ids_hash level message
dd2f1b86dac929fa0edd921c640b044d91d51247abdb4d28948c94052f404343 1 Failed to lookup field type array (
0 => 'filefield',
1 => 'imagefield__lightbox2__product_full__original',
) in the static map.
1b9f9e51af719beffd9c2c04ef5e36d1d236d0dbb1c20f45a67664ad5c0507f2 1 Failed to lookup field type array (
0 => 'filefield',
1 => 'imagefield__lightbox2__product_full_thumbs__original',
) in the static map.
dd2f1b86dac929fa0edd921c640b044d91d51247abdb4d28948c94052f404343 1 Failed to lookup field type array (
0 => 'filefield',
1 => 'imagefield__lightbox2__product_full__original',
) in the static map.
1b9f9e51af719beffd9c2c04ef5e36d1d236d0dbb1c20f45a67664ad5c0507f2 1 Failed to lookup field type array (
0 => 'filefield',
1 => 'imagefield__lightbox2__product_full_thumbs__original',
) in the static map.

Take this example:
imagefield__lightbox2__product_full_thumbs__original

imagefield = the module
lightbox2 = the image view module on theme display
product_full_thumbs = imagecache profile
original = the imagecache profile to show on click.

Not sure if this is normal or if there is a bug here. Not even sure if this is a migrate but or a commerce_migrate field override bug.

It blocks the migration with this error:

PHP Fatal error: Call to a member function getConfigDependencyName() on null in /web/core/lib/Drupal/Core/Entity/EntityDisplayBase.php on line 314

Response for point 2)
I think the issue is in d6_node_type:

In the migrate_map_d6_node_type table I have nodes like webforms:
webform, webform, 0, 1, 0, ''
I also have ubercart products:
product, NULL, 2, 0, 0, ''

With respect to this migration - d6_ubercart_product_type, I have several warning messages "Config entities can not be stubbed.". I also have 2 tables:
migrate_map_d6_ubercart_product_type - this has an entry:
product, NULL, 3, 0, 0, ''
and migrate_map_upgrade_d6_ubercart_product_type - this has an entry:
product, product, 0, 0, 0, ''

I can't see upgrade_d6_ubercart_product_type in the migration list though... this is weird!

OK, I think my base database has gotten mixed up at some stage, it seems to contain migration data already!!! Will reset and retry...

@quietone, great news. Bar a few, minor issue, I think I've got a full migration working!

Issue 1:
d6_ubercart_language_content_settings - seems to try and import content types that are not products

Issue 2:
d6_field_formatter_settings gives the following error and causes a fatal error:
Failed to lookup field type array (
 0 => 'filefield',
 1 => 'imagefield__lightbox2__product_full__original',
) in the static map.
PHP Fatal error: Call to a member function getConfigDependencyName() on null in
/web/core/lib/Drupal/Core/Entity/EntityDisplayBase.php on line 314

Apart from that, I think I've got everything working!
Congratulations, and thanks so much for all the help along the way!

Hi, sorry, didn't see the response...

Issue 1: There are other node types in my migration but they are not of type uc_product%. Is there any more info I can give you to help you figure it out? I might have to replicate the migration and debug, where should I look?

Issue 2: In d6 that is an image view preset with imagefield + imagecache + lightbox, it defines that the image should show an imagecache of "product_full" to start, and "original" when opening in lightbox. Image field is enabled in d8. Maybe this is something we don't want to fix, or maybe we could detect lightbox2 and ignore anything after to fail gracefully.

Hi @quietone.
I have noticed that fields that only belong to nodes (non-product fields) are not being migrated and I think I know why but not sure if the problem is really elsewhere. Its related to a migration error I have spotted before but not been able to fix...

[error] Attempt to create a field storage field_page_header with no entity_type. (web/core/modules/field/src/Entity/FieldStorageConfig.php:255)
[error] Attempt to create a field storage field_affiliate_logo with no entity_type. (web/core/modules/field/src/Entity/FieldStorageConfig.php:255)
[error] Attempt to create a field storage field_affiliate_website with no entity_type. (web/core/modules/field/src/Entity/FieldStorageConfig.php:255)

I think the issue comes from \Drupal\commerce_migrate_ubercart\EventSubscriber\prepareRow, specifically this block:

if ($i > 0) {
        if ($i == count($instances)) {
          // If all bundles for this field are product types, then change the
          // entity type to 'commerce_product'.
          $row->setSourceProperty('entity_type', 'commerce_product');
        }
        else {
          // This field is used on both nodes and products. Set
          // ubercart_entity_type so that field storage is created for the
          // ubercart product.
          $row->setSourceProperty('ubercart_entity_type', 'commerce_product');
          $row->setSourceProperty('entity_type', 'node');
        }
      }

I think we are missing an else on the if ($i > 0), basically what this bit of code is saying is - "If this field belongs to any known product types", which in the case of this field - doesn't, then set the source property "entity_type" = "node".
What Im finding is that fields which do not relate to products are not given an entity_type value in the $row->source therefore are not migrated. I think the code should be this...

if ($i > 0) {
        if ($i == count($instances)) {
          // If all bundles for this field are product types, then change the
          // entity type to 'commerce_product'.
          $row->setSourceProperty('entity_type', 'commerce_product');
        }
        else {
          // This field is used on both nodes and products. Set
          // ubercart_entity_type so that field storage is created for the
          // ubercart product.
          $row->setSourceProperty('ubercart_entity_type', 'commerce_product');
          $row->setSourceProperty('entity_type', 'node');
        }
else {
  // This field doesn't belong to any product, just set the destination entity to node.
  $row->setSourceProperty('entity_type', 'node');
}

Hi, anyone had a chance to look at this?
With this code change, I was able to do a complete migration of non-product entities and its respective fields

Here's a patch if it makes things easier...