Closed (fixed)
Project:
Search API
Version:
8.x-1.x-dev
Component:
Framework
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
14 Jan 2018 at 19:03 UTC
Updated:
29 Sep 2018 at 13:49 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
borisson_This is a start for this.
Comment #5
drunken monkeyThanks for starting on this!
The logic here seems inverted, it should just be
!empty($processor_definition['no_ui']).I think we can instead just make this another
check*Integration()method. We can even assert there that enabling the processor programmatically still works.Also, I guess specifically for processor, we simply need to adapt
\Drupal\search_api\Processor\ProcessorPluginBase::isHidden(). Doesn't work for any of the others, but still …(Also, contrary to the IS, I think we don't have any UI for search displays. Facets or other modules will have to take care of those.)
Maybe we should just move
isHidden()to ourConfigurablePluginInterfacebase interface (or even make an additional parent interface for that, to also catch data types and displays) to make this easier? Looking for a particular plugin definition key isn't exactly good DX.Anyways, I see no particular rush for fixing this issue, as it isn't really causing any problems. If we actually want to deprecate a plugin, or someone wants to use the
no_uikey for their own plugin for some reason, we can still work on it then.Comment #6
drunken monkeyHow about this? (Maximum suggested variant from #5, including a common interface and base class for all our plugin types. (It does add another method to all the plugin interfaces (except processors), but should be fine BC-wise since they all come with a plugin base class.))
To be a bit nicer regarding BC, I also refrained from changing the
getInstancesOptions()methods (for data types and parse modes). Not sure what people expect to get there, so better to keep it as-is.Comment #7
drunken monkeyAh, damn.
Comment #12
borisson_Sure, that sounds like a good idea. I think the getInstanceOptions thing is actually better like this. I haven't manually tested this yet - but it seems like the code looks great, it's a better change than the one I came up with.
The testbot doesn't seem happy yet though.
Comment #13
drunken monkeyHm, I can’t reproduce the problem normally in the UI. Anyways, I did spot one mistake, maybe this caused the test fails? (Tests run fine now locally.)
Comment #15
borisson_Looks great!
Comment #17
drunken monkeyExcellent, thanks for reviewing!
Committed.
Comment #18
drunken monkey