[D8]Vimeo field uploader

This issue has been posted in the correct issue queue, but then moved in the project queue, where no reviewer could see it. I am moving it back to the correct issue queue.

• Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
  • The INTRODUCTION section is missing.
  • The REQUIREMENTS section is missing.
  • The INSTALLATION section is missing.
  • The CONFIGURATION section is missing.
• Remove LICENSE.txt, it will be added by drupal.org packaging automatically.
• ./vimeo_field_uploader.module: All functions should be prefixed with your module/theme name (vimeo_field_uploader) to avoid name clashes. See https://www.drupal.org/node/318#naming
  

  function _vimeoupload_validate(&$form, FormStateInterface &$form_state) {
  

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
• DrupalPractice has found some issues with your code, but could be false positives.
  

  
  FILE: .../drupal-8/modules/vimeo_field_uploader/vimeo_field_uploader.info.yml
  --------------------------------------------------------------------------
  FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
  --------------------------------------------------------------------------
   1 | WARNING | "core_version_requirement" property is missing in the
     |         | info.yml file
  --------------------------------------------------------------------------
  
  Time: 172ms; Memory: 8MB
  

This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...ld_uploader/src/Plugin/Field/FieldWidget/VimeovideoDefaultWidget.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 110 | WARNING | Only string literals should be passed to t() where
     |         | possible
--------------------------------------------------------------------------


FILE: ...me/klausi/workspace/drupal-8/modules/vimeo_field_uploader/README.txt
--------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------
  6 | WARNING | [ ] Line exceeds 80 characters; contains 86 characters
 41 | ERROR   | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: .../drupal-8/modules/vimeo_field_uploader/vimeo_field_uploader.info.yml
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by
   |         | drupal.org packaging automatically
--------------------------------------------------------------------------


FILE: ...ce/drupal-8/modules/vimeo_field_uploader/vimeo_field_uploader.module
--------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------
 153 | WARNING | [ ] Only string literals should be passed to t() where
     |         |     possible
 190 | ERROR   | [x] Hook implementations must be documented with
     |         |     "Implements hook_example()."
 199 | WARNING | [ ] Only string literals should be passed to t() where
     |         |     possible
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 309ms; Memory: 10MB

manual review:

1. The Git commits are not connected to your user account. You need to specify an email address. See https://www.drupal.org/node/1022156 and https://www.drupal.org/node/1051722
2. class VimeoFieldUploader: doc block: don't simply repeat the class name, summarize what this class is used for.
3. LoadTest is a bit useless, it does not test any functionality of your module?
4. vimeo_field_uploader_form_alter(): will thorw lots of PHP notices and warnings because $entityType might now always be set. Please enable display of PHP notices/warnings in your development environment and fix uninitialized variable usage.
5. "if ($form_id == $formId) {": don't name 2 different variables like that. Instead use a more descriptive name so that code is easier to read. Like $target_form_id and $current_form_id.

Otherwise I don't see any security blockers, so I think we can approve this.

Thanks for your contribution, Ajay!

I updated your account so you can opt into security advisory coverage now.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on Slack or IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.