Problem/Motivation

If a webform handlers plugin file is removed or changed all of webform handler instances will marked permanantly as broken.

Steps to reproduce...

  • Add the 'Actions' to the 'Contact' webform (/admin/structure/webform/manage/contact/handlers)
  • Manually delete the plugin modules/sandbox/webform/src/Plugin/WebformHandler/ActionWebformHandler.php
  • Clear the cache
  • Go to the webform's 'Email/Handlers' page (/admin/structure/webform/manage/contact/handlers)
  • Click Save
  • Export the webform and confirm that the Action plugin's id is now permanantly set to 'broken' but the settings are still associated with the handler. (/admin/structure/webform/manage/contact/export/webform/)

Proposed resolution

Improve the messaging for broken handlers or figure out how not permanently mark a missing handler as broken.

The Views module has a similar issue and provides some override functionality.
\Drupal\views\Plugin\ViewsHandlerManager::getHandler

CommentFileSizeAuthor
#7 Selection_001.png61.73 KBMaheshwaran.j
#3 2935099-3.patch2.36 KBjrockowitz
#2 2935099-2.patch2.36 KBjrockowitz
Screen Shot 2018-01-08 at 5.50.36 AM.png32.93 KBjrockowitz

Comments

jrockowitz created an issue. See original summary.

jrockowitz’s picture

jrockowitz commented
Status: Active » Needs review
StatusFileSize
new 2935099-2.patch2.36 KB
jrockowitz’s picture

jrockowitz commented
StatusFileSize
new 2935099-3.patch2.36 KB

  • jrockowitz committed a65d3f5 on 8.x-5.x 
    Issue #2935099 by jrockowitz: Once a webform handler is marked as broken...
Maheshwaran.j’s picture

Maheshwaran.j commented
Assigned: Unassigned » Maheshwaran.j
jrockowitz’s picture

jrockowitz commented
Status: Needs review » Fixed

@Maheshwaran.j I committed the patch. Please download the latest dev release to review.

Maheshwaran.j’s picture

Maheshwaran.j commented
StatusFileSize
new Selection_001.png61.73 KB

@jrockowitz
Sorry for the delayed reply.
I did not download the new dev release, I pulled code from an 8.x-5.x branch, I downloaded the patch and applied but I was unsuccessful.
Am I missing something.?

Maheshwaran.j’s picture

Maheshwaran.j commented
Assigned: Maheshwaran.j » Unassigned
jrockowitz’s picture

jrockowitz commented

The patch has already been applied to 8.x-5.x-dev.

Maheshwaran.j’s picture

Maheshwaran.j commented

@jrockowitz
My bad, Yes I did not notice when I pulled the code, Sorry.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.