Hi,

Please find the list of drupal coding standard issues.

  • Remove the LICENSE, drupal.org packaging will add a LICENSE.txt file automatically.
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
    
    FILE: /root/repos/pareviewsh/pareview_temp/mask_user_data.info.yml
    --------------------------------------------------------------------------
    FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
    --------------------------------------------------------------------------
     1 | WARNING | [ ] Remove "version" from the info file, it will be added
       |         |     by drupal.org packaging automatically
     6 | ERROR   | [x] Expected 1 newline at end of file; 0 found
    --------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    --------------------------------------------------------------------------
    
    Time: 125ms; Memory: 6Mb
    
  • Codespell has found some spelling errors in your code.
    ./README.md:57: overriden  ==> overridden
    
  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.
CommentFileSizeAuthor
#2 code-2934859-2.patch953 bytessarguna raj m

Comments

sarguna raj M created an issue. See original summary.

sarguna raj m’s picture

Assigned: sarguna raj m » Unassigned
Status: Needs work » Needs review
StatusFileSize
new953 bytes

I have created a patch for the same.
Please review. :)

fjgarlin’s picture

Status: Needs review » Fixed

Hi, thanks for the patch. This was the very first commit of the 8.x branch so a lot will happen within the next weeks. Unit tests is in the roadmap too. Best.

fjgarlin’s picture

Status: Fixed » Closed (fixed)