The following errors and warnings need to be fixed:
Code change require

CommentFileSizeAuthor
#11 deploy_improve-coding-based-on-drupal-standards_2934343_11.patch18.4 KBdavi.uezono
#10 deploy_improve-coding-based-on-drupal-standards_2934343_10.patch20.26 KBdavi.uezono
#7 apply_patch.png561.67 KBsivaprasadc
#3 coding_standards-12407154-2.patch17.78 KBsivaprasadc
coding_change.png145.74 KBvenkatesh rajan.j

Comments

Venkatesh Rajan.J created an issue. See original summary.

sivaprasadc’s picture

sivaprasadc commented
Assigned: Unassigned » sivaprasadc
sivaprasadc’s picture

sivaprasadc commented
StatusFileSize
new coding_standards-12407154-2.patch17.78 KB

Hi,

Here is a patch that fixes the coding standards for 8.x-1.x-dev. Hope it helps. PFA
Thanks.

sivaprasadc’s picture

sivaprasadc commented
Assigned: sivaprasadc » Unassigned
Status: Active » Needs review
davi.uezono’s picture

davi.uezono commented
Status: Needs review » Reviewed & tested by the community

no issues found when running
deploy$ phpcs --standard=Drupal .

jeqq’s picture

jeqq commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll 
$ git apply --check < coding_standards-12407154-2.patch
error: patch failed: src/Entity/Form/ReplicationForm.php:150
error: src/Entity/Form/ReplicationForm.php: patch does not apply
sivaprasadc’s picture

sivaprasadc commented
Status: Needs work » Needs review
StatusFileSize
new apply_patch.png561.67 KB

@jeqq

I hope the current branch is 8.x-1.x. It applied correctly, please find the attached Screenshot.

Is I'm doing anything wrong?

jeqq’s picture

jeqq commented
Status: Needs review » Needs work

@Sivaprasad C you are doing it correctly but most probably you don't have the latest changes locally. Try to pull latest commits and try to apply the patch.

davi.uezono’s picture

davi.uezono commented
Assigned: Unassigned » davi.uezono

work in progress

davi.uezono’s picture

davi.uezono commented
Assigned: davi.uezono » Unassigned
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new deploy_improve-coding-based-on-drupal-standards_2934343_10.patch20.26 KB
davi.uezono’s picture

davi.uezono commented
StatusFileSize
new deploy_improve-coding-based-on-drupal-standards_2934343_11.patch18.4 KB

Sorry, I downloaded the source code through drush dl instead of git clone, that was my mistake.
Newer version attached.

Thanks for your patience with newbies like me.

venkatesh rajan.j’s picture

venkatesh rajan.j commented
Assigned: Unassigned » venkatesh rajan.j
venkatesh rajan.j’s picture

venkatesh rajan.j commented
Assigned: venkatesh rajan.j » Unassigned
Status: Needs review » Needs work

@davi.uezono,

All the errors have been fixed by your patch but there is one more warning left to be fixed


FILE: .../drupal-8.4.3/modules/deploy/src/Entity/Form/ReplicationForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 67 | WARNING | Only string literals should be passed to t() where
    |         | possible
----------------------------------------------------------------------
davi.uezono’s picture

davi.uezono commented

Yes. Following this thread, I thought it would be considered a false positive warning. I have also considered this blog article: https://chromatichq.com/blog/drupal-code-standards-t-function.

Not sure what to consider by those readings. Any thoughts?

jeqq’s picture

jeqq commented
jeqq’s picture

jeqq commented
Status: Needs work » Fixed

Thank you!

I've committed this and assigned the credits accordingly, but for some reasons the commits don't appear in this issue. You can see the commits here: https://www.drupal.org/node/230088/commits

I hope it's just a drupal.org delay.

  • jeqq committed 24c30df on 8.x-1.x authored by Sivaprasad C 
    Issue #2934343 by davi.uezono, Sivaprasad C, jeqq: Improve coding based...
  • jeqq committed 8b29ca9 on 8.x-1.x
    Issue #2934343 by Venkatesh Rajan.J, jeqq: Improve coding based on...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.