If I add a payment incorrectly, there is no way for me to remove or undo it. We should probably have a remove button beside the payment like the 7.x version does.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | remove-payments-2934019-12.patch | 31.67 KB | sorabh.v6 |
| #12 | remove-payments-2934019-interdiff-9-12.txt | 2.59 KB | sorabh.v6 |
| #9 | remove-payments-2934019-9.patch | 31.43 KB | smccabe |
Comments
Comment #2
thejacer87 commentedstarted hooking some stuff up. the #table => #rows doesn't seem to want to render the form button (shawn said to make this a link like in commerce 1)
Comment #3
thejacer87 commentedComment #4
thejacer87 commentedComment #5
smccabe commentedJace, you should be able to update the main POSFormTest to check this functionality as well, just an extra step once to void and then add another payment, check the totals. If you look at the existing test it should be mostly copy/paste.
Comment #6
thejacer87 commentedhere's the patch, i think the tests will work. but i couldn't figure out how to run them. will keep trying
Comment #7
thejacer87 commentedComment #9
smccabe commentedRerolled patch, but tests still failing.
Comment #11
sorabh.v6Comment #12
sorabh.v6Updated POSFormTest. It should now pass tests.
Comment #14
smccabe commentedAdded in some small phpcs fixes, mostly general ones, not specific to this patch.