If I add a payment incorrectly, there is no way for me to remove or undo it. We should probably have a remove button beside the payment like the 7.x version does.

Comments

smccabe created an issue. See original summary.

thejacer87’s picture

StatusFileSize
new2.63 KB

started hooking some stuff up. the #table => #rows doesn't seem to want to render the form button (shawn said to make this a link like in commerce 1)

thejacer87’s picture

StatusFileSize
new62.28 KB
thejacer87’s picture

Status: Active » Needs review
smccabe’s picture

Status: Needs review » Needs work

Jace, you should be able to update the main POSFormTest to check this functionality as well, just an extra step once to void and then add another payment, check the totals. If you look at the existing test it should be mostly copy/paste.

thejacer87’s picture

Status: Needs work » Needs review
StatusFileSize
new64.72 KB

here's the patch, i think the tests will work. but i couldn't figure out how to run them. will keep trying

thejacer87’s picture

StatusFileSize
new2.74 KB

Status: Needs review » Needs work

The last submitted patch, 6: remove-payments-2934019-6.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

smccabe’s picture

Status: Needs work » Needs review
StatusFileSize
new31.43 KB

Rerolled patch, but tests still failing.

Status: Needs review » Needs work

The last submitted patch, 9: remove-payments-2934019-9.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

sorabh.v6’s picture

Assigned: Unassigned » sorabh.v6
sorabh.v6’s picture

Assigned: sorabh.v6 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new2.59 KB
new31.67 KB

Updated POSFormTest. It should now pass tests.

  • smccabe committed 327ccb8 on 8.x-2.x authored by sorabh.v6
    Issue #2934019 by thejacer87, sorabh.v6, smccabe: Allow payments to be...
smccabe’s picture

Status: Needs review » Fixed

Added in some small phpcs fixes, mostly general ones, not specific to this patch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.