Needs work
Project:
Commerce Point of Sale (POS)
Version:
8.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
2 Jan 2018 at 11:05 UTC
Updated:
1 Oct 2018 at 10:48 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
deepakaryan1988Comment #3
deepakaryan1988Please review this.
Comment #4
smccabe commentedHey @deepak, if you search for entity_type.manager you'll see that it is used in at least 4 other places, you'll need to clean those up and anything that depends on them.
Comment #5
deepakaryan1988Comment #6
travis-bradbury commentedComment #7
mglamanThere is no work to be done here, for now.
In \Drupal\commerce_pos\POS it is passing the deprecated manager because it has to.
May as well postpone as all usage is required by core.
Comment #8
joshmillerWe're back at active, because 8.6.x HEAD now has committed a change to the ContentEntityForm to remove the deprecated service.
#2894261: Deprecated service entity.manager needs to be replaced with entity_type.manager in ContentEntityForm
Comment #9
quietone commentedNeeds a reroll
Comment #10
quietone commentedNow change the POSForm constructor.
Not running tests and setting to NW because not user what to do with this usage of $entity_manager, which was added in 2950975-#9