See #2824851-205: EntityResource::patch() makes an incorrect assumption about entity keys, hence results in incorrect behavior. According to #2930968: PATCHing entities with langcode = [] results in fatal error, this hunk doesn't seem to be working anyway, and a proper error response can be added in that issue.

Splitting this change out from #2824851: EntityResource::patch() makes an incorrect assumption about entity keys, hence results in incorrect behavior so that it can be evaluated/committed on its own, rather than as an out of scope side effect of that issue.

CommentFileSizeAuthor
#16 2933408-nr-bot.txt148 bytesneeds-review-queue-bot
#2 rest-entity-patch-langcode.patch890 byteseffulgentsia

Comments

effulgentsia created an issue. See original summary.

effulgentsia’s picture

effulgentsia commented
StatusFileSize
new rest-entity-patch-langcode.patch890 bytes
effulgentsia’s picture

effulgentsia commented

Some background: #2183231-260: Make ContentEntityDatabaseStorage generate static database schemas for content entities is what added this special-casing of langcode to begin with. #2183231-264: Make ContentEntityDatabaseStorage generate static database schemas for content entities explains why that was done. I don't know if there ever was a followup since then to fix the underlying problem referenced in that comment. If so, that would be one possible explanation for why this code isn't needed anymore.

Additionally, at the time of the above, isEmpty() was being checked below this code to switch on whether to check field access for 'delete' or 'update'. #2418119-48: REST user updates bypass tightened user account change validation, however, changed that to just 'edit' in either case. I don't know if that change would have also potentially made this code no longer needed.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: +API-First Initiative
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: Unassigned » berdir
Related issues: +#2824851: EntityResource::patch() makes an incorrect assumption about entity keys, hence results in incorrect behavior, +#2183231: Make ContentEntityDatabaseStorage generate static database schemas for content entities, +#2143729: Entity definitions miss a language entity key, +#2930968: PATCHing entities with langcode = [] results in fatal error

#2824851 landed. As #2824851-205: EntityResource::patch() makes an incorrect assumption about entity keys, hence results in incorrect behavior discovered that #2183231: Make ContentEntityDatabaseStorage generate static database schemas for content entities added these lines of code, and #2143729: Entity definitions miss a language entity key refined it further.

But #2930968: PATCHing entities with langcode = [] results in fatal error is indicating it doesn't work anyway.

Since Berdir has been active in all of these issues, I think he's probably best able to review this … assigning to him.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 2933408-nr-bot.txt148 bytes

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.