The latest update of the Login Destination module cause this issue.

UnexpectedValueException: External URLs do not have an internal route name. in Drupal\Core\Url->getRouteName() (line 555 of /home/sitename/web/core/lib/Drupal/Core/Url.php).

This commit made the issue
#2820772: Store current page to redirect back to after following login link and logging in - not working in D8
#2931356: Fixed Route Error as links should be routed ( is routed ) before we get their route name

The problem is in login_destination_link_alter

CommentFileSizeAuthor
#7 2931502-7.patch1.07 KBrajab natshah

Comments

yasmeensalah created an issue. See original summary.

yasmeensalah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes

Thank you for reporting!
I think our best option is to patch the module after
944d78fbf01853244d8e01f63b41dc37d5f99e50

http://cgit.drupalcode.org/login_destination/log/?h=8.x-1.x

We could add the patch in #2931356: Fixed Route Error as links should be routed ( is routed ) before we get their route name as you reported that in the private.

rajab natshah’s picture

Assigned: Unassigned » rajab natshah
Status: Active » Needs work
rajab natshah’s picture

rajab natshah’s picture

After Reading Omar Alahmed's comment on this link
https://api.drupal.org/comment/63563#comment-63563
links should be Routed.

rajab natshah’s picture

StatusFileSize
new1.07 KB

Applying the Patch #5 2931356-5.patch in #2931356: Fixed Route Error as links should be routed ( is routed ) before we get their route name for Varbase 8.4.13

And you could add the patch in your varbase-project patches as follows:

   "patches": {
      "drupal/login_destination": {
        "Issue #2931356: Fixes Route Error.":
        "https://www.drupal.org/files/issues/2931356-5.patch"
      }
   }
rajab natshah’s picture

Title: [Login Destination] Route Error » Fixed the issue of [Login Destination] Route Error with get route needed the link to be Routed

rajab natshah’s picture

rajab natshah’s picture

Assigned: rajab natshah » mohammed j. razem
Status: Needs work » Needs review
Issue tags: +varbase-8.4.14
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
yas’s picture

FYI, I received that error in the combination of Login Destination 8.x-1.x-dev on Drupal core 8.5-dev:

UnexpectedValueException: External URLs do not have an internal route name. in Drupal\Core\Url->getRouteName() (line 555 of /home/sitename/web/core/lib/Drupal/Core/Url.php).

And in that case, thhe patch of #2931356: Fixed Route Error as links should be routed ( is routed ) before we get their route name worked for me.

rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

Status: Fixed » Closed (fixed)