Follow up for #2782479: Replace deprecated usage of \Drupal::url with Url::fromRoute:

Replace deprecated usage of \Drupal::url with Url::fromRoute

https://api.drupal.org/api/drupal/core!lib!Drupal.php/function/Drupal%3A...

CommentFileSizeAuthor
#4 math-captcha.png55.58 KBsarguna raj m
#4 image-captcha.png62.98 KBsarguna raj m
#2 captcha-Url_fromRoute-2931385-2.patch3.38 KBhswong3i

Comments

hswong3i created an issue. See original summary.

hswong3i’s picture

hswong3i commented
StatusFileSize
new captcha-Url_fromRoute-2931385-2.patch3.38 KB
sarguna raj m’s picture

sarguna raj m commented
Assigned: Unassigned » sarguna raj m
sarguna raj m’s picture

sarguna raj m commented
Assigned: sarguna raj m » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new image-captcha.png62.98 KB
new math-captcha.png55.58 KB

Hi hswong3i,

I have tested the patch #2 manually and it seems to be working fine.
Tested the both Math and image captcha.

Please refer the attached screenshots.

wundo’s picture

wundo commented
wundo’s picture

wundo commented
Version: 8.x-1.0-beta1 » 8.x-1.x-dev
wundo’s picture

wundo commented
wundo’s picture

wundo commented
Status: Reviewed & tested by the community » Needs review

@sarguna doesn't look like you're actually testing what he fixed. He changed something internal not the actual captcha.

magicmyth’s picture

magicmyth commented
Status: Needs review » Reviewed & tested by the community

Just tested this patch on the latest dev version. It actually resolved an issue I was seeing on a new install:

Warning: strpos() expects parameter 1 to be string, object given in Drupal\Component\Utility\UrlHelper::stripDangerousProtocols() (line 352 of core/lib/Drupal/Component/Utility/UrlHelper.php).
Drupal\Component\Utility\UrlHelper::stripDangerousProtocols(Object) (Line: 205)
Drupal\Component\Render\FormattableMarkup::placeholderFormat('Note that the CAPTCHA module disables <a href=":performancesettings">page caching</a> of pages that include a CAPTCHA challenge.', Array) (Line: 204)
Drupal\Core\StringTranslation\TranslatableMarkup->render() (Line: 15)
...

I've tested with Drupal core's contact form (as a block with contact_block) with both the maths captcha and ReCaptcha.

  • elachlan committed 363bdbb on 8.x-1.x authored by hswong3i 
    Issue #2931385 by hswong3i: Replace deprecated usage of \Drupal::url...
elachlan’s picture

elachlan commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.