Convert module to use short array syntax (new coding standard)

@pvsureshmca, Thanks for correcting this standard error, But I found some more files in which this change should be reflected.
Also, You can check the review of standard missing file errors in pareview.sh. I attached one screenshot which indicates the same.
Move to Needs work As files are still remaining.

This is not a major bug. Cosmetic code-style fixes are a normal task (at most).

Furthermore, @dhwani.addweb: some of those files you're talking about aren't even "Drupal" files as such. They're a hard-coded copy of an external library that should be removed entirely and loaded via Composer. See #2711559: Set phpMailer as a external library using composer (and update it to 6.0).

Cheers,
-Derek

Replaced array to short syntax and replaces t() to $this->t() at classes

Can we keep the t() to $this->t() out of this patch and handle that in a separate issue? Combining unrelated changes in a single patch/issue makes life difficult for everyone.

Thanks,
-Derek

Edited patch. Removed changes for t()

Tested latest patch and the issues are removed.Thanks @ToxaViking

This patch needs a re-roll as most of the long array syntax were already fixed by other issues.

There are three commits towards this issue but it's still open? Is it resolved?

Almost. Other than the upstream source from PHPMailer, there are only 2 remaining usages (in doc comments, not code).

For completeness, this would fix the last of it.

RTBC'd @dww's patch in #16.

Did you not push the commit? I just pulled and as of commit 90c44f68792 those code comments are still using array().

Thanks,
-Derek

Yes, I missed the push, sorry.

Cool, thanks!

Cheers,
-Derek