in redirect.links.menu.yml the 'Add redirects' menu item is set to redirect.list route. It should be set to redirect.add route.

CommentFileSizeAuthor
#11 Changed link and title ref.png34.86 KBkiruba karan
#10 Wrong_route_for_Add_redirects_menu_item-2930347-10.patch396 bytesarunkumark
#3 Wrong_route_for_Add_redirects_menu_item-2930347-3.patch349 bytesaxelc

Comments

Jody Lynn created an issue. See original summary.

mr.baileys’s picture

mr.baileys
Primary language Dutch
Location 🇧🇪 (Ghent)
commented
Issue tags: +Quick fix, +Novice
axelc’s picture

axelc commented
StatusFileSize
new Wrong_route_for_Add_redirects_menu_item-2930347-3.patch349 bytes
axelc’s picture

axelc commented
Status: Active » Needs review
axelc’s picture

axelc commented
mr.baileys’s picture

mr.baileys
Primary language Dutch
Location 🇧🇪 (Ghent)
commented
Status: Needs review » Reviewed & tested by the community

Branch is still failing due to #2929832: Move migration_templates directory to migrations, so no automated tests for now.

I've reviewed the patch, and manually tested it on simplytest.me, RTBC.

jody lynn’s picture

jody lynn
she/her
Primary language English
commented

Thanks axelc and mr.baileys

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Needs work 
+++ b/redirect.links.menu.yml
@@ -8,7 +8,7 @@ redirect.list:
 redirect.add:
   title: 'Add redirects'
   parent: redirect.list

While touching this, lets also fix the title to be Add redirect, you can't add multiple redirects at once and then it is consistent with the local task.

arunkumark’s picture

arunkumark
Location Coimbatore
commented
Assigned: Unassigned » arunkumark
arunkumark’s picture

arunkumark
Location Coimbatore
commented
Assigned: arunkumark » Unassigned
Status: Needs work » Needs review
StatusFileSize
new Wrong_route_for_Add_redirects_menu_item-2930347-10.patch396 bytes

As per the comment #8 i have updated the patch.

kiruba karan’s picture

kiruba karan commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Changed link and title ref.png34.86 KB

Able to add the patch through command prompt. Also, I have tested this functionality. Both the link and title are changed and working as expected. Here I attached the screenshot for the reference.

  • Berdir committed 591a9ad on 8.x-1.x authored by axelc 
    Issue #2930347 by axelc, arunkumark, kiruba karan: Wrong route for 'Add...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.