If I run Redirect's unit tests locally, I get 6 failures:

<snip>
6) Drupal\Tests\redirect\Unit\EventSubscriber\RouteNormalizerRequestSubscriberTest::testOnKernelRequestRedirect with data set #2 ('https://example.com/index.php/', array('node/1'), 'https://example.com/?q=node/1', true)
Argument 2 passed to Drupal\Tests\redirect\Unit\EventSubscriber\RouteNormalizerRequestSubscriberTest::getGetResponseEventStub() must be of the type array, string given, called in /redirect/tests/src/Unit/RouteNormalizerRequestSubscriberTest.php on line 84 and defined

The signature for \Drupal\Tests\redirect\Unit\EventSubscriber\RouteNormalizerRequestSubscriberTest::getGetResponseEventStub() has the second parameter, $query_string, incorrectly typed as array. Seems to have been introduced by #2854462: Needs tests: Disable route normalizer for core routes..

Comments

mr.baileys created an issue. See original summary.

berdir’s picture

what core and php version? Doesn't seem to fail on testbot like that?

berdir’s picture

StatusFileSize
new1.47 KB

Because it is in the wrong namespace. This should fix that.

  • Berdir committed e52cf05 on 8.x-1.x authored by mr.baileys
    Issue #2929869 by mr.baileys, Berdir: UnitTests are failing
    
berdir’s picture

Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.