According to #2920988: Renamed migrations_templates directory to migrations migration_templates should be moved to migrations in order to avoid testing fails for deprecated code.

CommentFileSizeAuthor
#2 2929832-1_rename-migration_templates-folder-migration.patch410 bytesalvar0hurtad0

Comments

alvar0hurtad0 created an issue. See original summary.

alvar0hurtad0’s picture

alvar0hurtad0
he/him
Primary language Spanish
Location Cáceres
commented
StatusFileSize
new 2929832-1_rename-migration_templates-folder-migration.patch410 bytes
mr.baileys’s picture

mr.baileys
Primary language Dutch
Location 🇧🇪 (Ghent)
commented

Branch tests are failing at the moment due to this issue. Patch in #2 was waiting for branch to pass, I started the test manually so we can verify that this indeed makes the branch tests pass again.

mr.baileys’s picture

mr.baileys
Primary language Dutch
Location 🇧🇪 (Ghent)
commented
Status: Active » Reviewed & tested by the community

Patch correctly moves the migration yaml's from migration_templates/ to migations/ as directed in #2920988: Renamed migrations_templates directory to migrations, and tests show that this makes the branch pass again, so RTBC.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Of course the problem is that this is only in 8.5.x, so by committing this patch, we break migrate integration on 8.4.x.

I've changed the patch testing configuration to use the supported branch, which is 8.4.x, so this is postponed until 8.5.0 is out.

  • Berdir committed 5b2d1e3 on 8.x-1.x authored by alvar0hurtad0 
    Issue #2929832 by alvar0hurtad0: Move migration_templates directory to...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Actually, this was already deprecated in 8.1.0, the change record is confusing.

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.