Core seems to have made a lot of progress regarding coding standards lately – comparing their phpcs.xml.dist file with our phpcs.xml yields a lot of rules they're already following and which we don't test for – some we even violate.
We should add as many more rules from Core as possible and fix violations where it makes sense.

CommentFileSizeAuthor
#2 2929739-2--coding_standards.patch19.86 KBdrunken monkey

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Active » Needs review
StatusFileSize
new 2929739-2--coding_standards.patch19.86 KB
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

Woo!

  • drunken monkey committed dff16be on 8.x-1.x 
    Issue #2929739 by drunken monkey, borisson_: Improved adherence to...
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Fixed

"Woo" indeed. ;) Thanks for reviewing!
Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.