if an exception is thrown during $mc_lists->getInterests() it is not caught and in my experience would bring the site down. I'll attach a patch that wraps in a try/catch block.

CommentFileSizeAuthor
#5 2928786-uncaught-exception--5.1.patch1.1 KBaklump
#2 2928786-uncaught-exception.patch911 bytesaklump

Comments

aklump created an issue. See original summary.

aklump’s picture

aklump commented
StatusFileSize
new 2928786-uncaught-exception.patch911 bytes
aklump’s picture

aklump commented

If you wanted to roll this other one in at the same time, it deals with almost the same lines of code: https://www.drupal.org/project/mailchimp/issues/2835243

lennart’s picture

lennart commented

I can confirm this issue

aklump’s picture

aklump commented
Version: 7.x-5.0 » 7.x-5.1
Priority: Major » Critical
StatusFileSize
new 2928786-uncaught-exception--5.1.patch1.1 KB

Making this critical as it takes the prod site down when it happens. I'm attaching an updated patch to work with version 7.x-5.1.

  • ruscoe committed 123230b on 7.x-5.x authored by aklump 
    Issue #2928786 by aklump: mailchimp_interest_groups_form_elements() may...
ruscoe’s picture

ruscoe commented
Status: Active » Fixed

Thanks for this. I've committed your first patch to deal with the critical issue.

I see the other issue you mentioned in #3 and will get that into an upcoming release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.