1. User should get a notification when another user comments on a topic you commented.
  2. User automatically follows a topic if he comments on it.
  3. User should be able to toggle those notifications on and of per item (via unfollow).
  4. This auto follow should be mentioned in the success message when you post a comment.
CommentFileSizeAuthor
#7 Screen Shot 2018-06-11 at 17.13.44.png35.42 KBEvelienschut

Comments

chmez created an issue. See original summary.

ohorbatiuk’s picture

ohorbatiuk
he/him/his
Primary language Ukrainian
Location Ukraine 🇺🇦
commented
Status: Active » Needs review

https://github.com/goalgorilla/open_social/pull/652

jochemvn’s picture

jochemvn commented

Good idea for a feature... We want this for events too. Basically for all nodes (pages/books/custom ones).

jochemvn’s picture

jochemvn commented
Status: Needs review » Needs work
ohorbatiuk’s picture

ohorbatiuk
he/him/his
Primary language Ukrainian
Location Ukraine 🇺🇦
commented
Assigned: Unassigned » ohorbatiuk
ohorbatiuk’s picture

ohorbatiuk
he/him/his
Primary language Ukrainian
Location Ukraine 🇺🇦
commented
Assigned: ohorbatiuk » Unassigned
Status: Needs work » Needs review

I did it for events.

Evelienschut’s picture

Evelienschut commented
StatusFileSize
new Screen Shot 2018-06-11 at 17.13.44.png35.42 KB

I have seen this issue on Pachamama and i noticed that the message about you following the topic is not very clear. Not sure if that is already changed in this request, if not please change it!
See screenshot for the message "You were followed to a content of this topic"

ohorbatiuk’s picture

ohorbatiuk
he/him/his
Primary language Ukrainian
Location Ukraine 🇺🇦
commented

@evelienschut, how should that message be changed?

xinyuma’s picture

xinyuma commented

The text could be:

  • Your comment has been posted.
  • You will also be following this topic automatically. Unfollow

The unfollow should be a button.

NatashaSchon’s picture

NatashaSchon commented

What about this?

  • Your comment has been posted.
  • You are now automatically following this topic. Unfollow.
xinyuma’s picture

xinyuma commented

That is much better, thanks Natasha!

jaapjan’s picture

jaapjan commented
Version: 8.x-1.x-dev » 8.x-2.x-dev

Thanks guys! I've update the PR with the latest change. Ready for review.

jaapjan’s picture

jaapjan commented
Status: Needs review » Needs work

After reviewing marking this one as "needs work" again.

When you comment you are automatically following the content, which is nice! But if you then unfollow the content manually and comment on the node again you are automatically following the topic again. My fear is that this will be super annoying for some users. And this feature is only there to accommodate for people who can't find the Follow button themselves. Video of this issue can be found here: https://github.com/goalgorilla/open_social/files/2159816/follow-topic-wh...

The only solution for the issue above is if we can somehow detect if someone unfollowed the content before and then we can prevent to let the user follow the content automatically again. It won't be easy since the Flag module does not currently keep records of previous flags in the database.

I suggest not to merge this before the issue above is solved.

bramtenhove’s picture

bramtenhove commented
Version: 8.x-2.x-dev » 8.x-3.x-dev
Category: Task » Feature request
bramtenhove’s picture

bramtenhove commented
Status: Needs work » Needs review

I reviewed the current pull request and added an option to unfollow the content in the confirmation message. This should help in the case described above.

https://github.com/goalgorilla/open_social/pull/652

ronaldtebrake’s picture

ronaldtebrake commented
Status: Needs review » Reviewed & tested by the community
ronaldtebrake’s picture

ronaldtebrake commented
Status: Reviewed & tested by the community » Fixed

Thanks will be in 4.0 today.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.