Autocomplete support does not respect role filter nor user permissions

That is not possible I think. Core does not implement this as I know, too. Or can you show the core function that allows this type of filtering?

If this is done every node form would break as it can no longer populate the author name just as one example. An author can be a user that is filtered by your code and than missing in autocomplete.

Than it is ok, but we need tests to make sure all this stuff works properly. I think I have not reviewed D8 about this, in D7 this is not the case and this was a forward port what explains why it may be missing.

Marking needs work for full test coverage.

Great simplification, but we still need tests.

1. +++ b/src/Tests/Kernel/RealnameEntityReferenceTest.php
   @@ -0,0 +1,100 @@
   +    $this->assertTrue(in_array($user1->label(), $users));
   +    $this->assertTrue(in_array($user2->label(), $users));
   +    $this->assertFalse(in_array($user3->label(), $users));
   

   Shouldn't this DisplayName?

2. +++ b/src/Tests/Kernel/RealnameEntityReferenceTest.php
   @@ -0,0 +1,100 @@
   +    $this->assertTrue(in_array($user1->label(), $users));
   +    $this->assertTrue(in_array($user2->label(), $users));
   +    $this->assertFalse(in_array($user3->label(), $users));
   

   Shouldn't this DisplayName?

Maybe we can use functions that are easier to read.

@plopesc

Patch in #9 is working perfectly in my use case. I spent 2 hours wondering why the role filter wasn't working as expected.

Searching for issues in my code, or related stuff in core, etc. I started to get really mad until I stumbled upon this issue, and your patch.

Many thanks for this, you saved my day.

#2 applied successfully and working fine .

Patch #2 applied succesfully

I believe he usage of label() method here makes the tests more solid, given that not only confirms that getDisplayName() works, it tests the label() and user_format_name() integration as well.

Sound not logic to me. getDisplayName() uses user_format_name() to generate the users real name with a fallback to the username. Can you explain how label can make it more solid, please?

I‘m not convinced with #2629286: Use getDisplayName() for user names consistently in mind.

Something is wrong with the patch. I ran the RealnameEntityReferenceTest on my machine and it always fails with

InvalidArgumentException: Invalid database prefix: in Drupal\Core\Test\TestDatabase->__construct() (Line 81 in \core\lib\Drupal\Core\Test\TestDatabase.php).

and
Notice: Undefined offset: -2 in Drupal\Core\Test\TestStatus::label() (Line 59 in \core\lib\Drupal\Core\Test\TestStatus.php)

and

Drupal\Core\Database\IntegrityConstraintViolationException: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'status' cannot be null: INSERT INTO {simpletest} (test_id, test_class, status, message, message_group, function, line, file) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3, :db_insert_placeholder_4, :db_insert_placeholder_5, :db_insert_placeholder_6, :db_insert_placeholder_7);

Sounds like Drupal.org is not running your test what is another problem.

ConfigCacheTag.php should be named RealnameConfigCacheTag.php

Aside why is installSchema() in setUp()? If you install a module all tables should be installed automatically.

Please update the patch so we can commit it.

#23

It appears that this patch causes autocomplete fields to search by account name, not the real name. Without the patch, autocomplete works on both real name and account name.

I've reapplied the patch against latest dev version and updated the plugin and tests. The realname search didn't work because the realname entity selection wasn't even selected. According to web/core/lib/Drupal/Core/Entity/Annotation/EntityReferenceSelection.php you need to use the $group in the annotation if you wish to extend an existing selection.

Patch in #29 no longer applies. Re-rolled for latest dev release.

This seems to be a related issue for the most recent module version - https://www.drupal.org/project/realname/issues/3276281

Re-rolled for the 2.0.0-beta2 and latest 2.x branch.

Re-rolled for 2.0.0.

Tested. The patch applies and works as advertised.

+1 for this

I created MR16 from the patch in #37 to help move this along.