As part of #2926791: All coding standard fixes , here's a patch to remove 45 unused 'use' statements, as reported in the current branch test https://www.drupal.org/pift-ci-job/820001

I went through each file and verified there was no usage of the removed classes/interfaces referenced by these 'use' statements, and I ran the Flag tests locally to ensure everything still works. The patch tests results will tell us if I missed any ... This patch should be fairly easy to review because you can easily see if there are any out-of-scope changes, and because it removes 'use' statements there will be test failures if the patch removed something it shouldn't have.

CommentFileSizeAuthor
unused-use.patch12.46 KBtr

Comments

TR created an issue. See original summary.

tr’s picture

I should also mention that this patch does NOT conflict with #2877902-15: Coding standard changes. There will be a few offsets when applying that after this one, but there are no conflicts.

martin107’s picture

Status: Needs review » Reviewed & tested by the community

A) After a visual scan of the patch ... nothing out of scope .. all looks good.

B) After a visual scan of testbot CS warnings

https://www.drupal.org/pift-ci-job/822224

There are no more unused used statements.

C) Tests are green

D) Patch applies 8.x-4.x

So all this is perfect .. thanks @TR

  • TR authored ce375ed on 8.x-4.x
    Issue #2926945 by TR, martin107, socketwench: Remove unused 'use'...
socketwench’s picture

Status: Reviewed & tested by the community » Fixed

Fixed with a small reroll. Thanks everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.