As part of #2926791: All coding standard fixes , here's a patch to remove 45 unused 'use' statements, as reported in the current branch test https://www.drupal.org/pift-ci-job/820001
I went through each file and verified there was no usage of the removed classes/interfaces referenced by these 'use' statements, and I ran the Flag tests locally to ensure everything still works. The patch tests results will tell us if I missed any ... This patch should be fairly easy to review because you can easily see if there are any out-of-scope changes, and because it removes 'use' statements there will be test failures if the patch removed something it shouldn't have.
| Comment | File | Size | Author |
|---|---|---|---|
| unused-use.patch | 12.46 KB | tr |
Comments
Comment #2
tr commentedI should also mention that this patch does NOT conflict with #2877902-15: Coding standard changes. There will be a few offsets when applying that after this one, but there are no conflicts.
Comment #3
martin107 commentedA) After a visual scan of the patch ... nothing out of scope .. all looks good.
B) After a visual scan of testbot CS warnings
https://www.drupal.org/pift-ci-job/822224
There are no more unused used statements.
C) Tests are green
D) Patch applies 8.x-4.x
So all this is perfect .. thanks @TR
Comment #5
socketwench commentedFixed with a small reroll. Thanks everyone!