Core has been on a mission to provide better coding standard warnings alongside testbot results.

The outcome, for the flag module, is that a lot more lint messages are appearing...

so many that new flaws introduced by the patch under test can easily get lost.

The issue is about getting the haystack down to a manageable size so we can spot the needle.

We should target single issue one per issue to make reviewing simpler.

This is just a parent issue to link single issues.

Issue fork flag-2926791

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

martin107 created an issue. See original summary.

martin107’s picture

martin107 commented
Issue summary: View changes
tr’s picture

tr commented
Related issues: +#2926945: Remove unused 'use' statements

OK, let me get the ball rolling with the first patch: #2926945: Remove unused 'use' statements

tr’s picture

tr commented
Related issues: +#2927103: Data types in @var tags need to be fully namespaced

And another #2927103: Data types in @var tags need to be fully namespaced

tr’s picture

tr commented
Related issues: +#2927108: Use short array syntax in flag.tokens.inc

And another: #2927108: Use short array syntax in flag.tokens.inc

martin107’s picture

martin107 commented
Related issues: +#2927121: Coding standard fix - remove blank line.

Can't let TR do all the work!

martin107’s picture

martin107 commented
Related issues: +#2927128: Case breaking statements must be followed by a single blank line
martin107’s picture

martin107 commented
Related issues: +#2929420: remove long array syntax
ivnish’s picture

ivnish
he/him
commented
Title: [meta] coding standard fixes » All coding standard fixes
Assigned: Unassigned » ivnish

ivnish opened merge request !93

  • ivnish committed 40257ad5 on 8.x-4.x 
    Issue #2926791 by ivnish: All coding standard fixes
ivnish’s picture

ivnish
he/him
commented
Assigned: ivnish » Unassigned
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.