Because of a change in core, tests will now throw exceptions if any deprecated APIs are used. This change is in core for 8.5.x so we have some time to update Metatag accordingly.

An example test run is https://www.drupal.org/pift-ci-job/818280 where it threw this error quite a lot:

exception: [User deprecated function] Line 308 of core/lib/Drupal/Core/Field/BaseFieldDefinition.php:
BaseFieldDefinition::setQueryable() is deprecated in Drupal 8.4.0 and will be removed before Drupal 9.0.0. Instead, you should use \Drupal\Core\Field\BaseFieldDefinition::setCustomStorage(). See https://www.drupal.org/node/2856563.

CommentFileSizeAuthor
#3 basefielddefinition-2925714-3.patch561 bytesvakulrai
#2 2925714-2.patch496 bytesacbramley

Comments

DamienMcKenna created an issue. See original summary.

acbramley’s picture

acbramley commented
Title: Replace all deprecated code » Replace deprecated BaseFieldDefinition ::setQueryable
Status: Active » Needs review
StatusFileSize
new 2925714-2.patch496 bytes

We should be able to just remove it since we're already setting the field as computed.

vakulrai’s picture

vakulrai commented
StatusFileSize
new basefielddefinition-2925714-3.patch561 bytes

Adding a patch which will replace deprecated method .

acbramley’s picture

acbramley commented

@vakulrai that's incorrect, a computed field must have custom storage. You can see this by the doc block on setCustomStorage:

   * @throws \LogicException
   *   Thrown if custom storage is to be set to FALSE for a computed field.
   */
  public function setCustomStorage($custom_storage) {
nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented

Tested #2 and it works as expected.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Agreed, #2 looks good and is enough.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #2957104: Plan for Metatag 8.x-1.6

Thanks for the review, @Berdir.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Fixed

Committed. Thank you.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Related issues: +#3088848: Drupal 9 release plan for Metatag (ETA: when D9.0.0-beta1 is released)