7.x defines:

  'access commerce reports' => array(
      'title' => t('Access commerce reports'),
    ),
CommentFileSizeAuthor
#4 Screen Shot 2018-01-29 at 3.48.38 PM.png20.97 KBsorabh.v6
#4 add_permissions.2924649-4.patch256 bytessorabh.v6
#4 add_permissions.2924649-interdiff-2-4.txt324 bytessorabh.v6
#2 add_permissions.2924649-2.patch267 byteschrisrockwell

Comments

chrisrockwell created an issue. See original summary.

chrisrockwell’s picture

chrisrockwell commented
Status: Active » Needs review
StatusFileSize
new add_permissions.2924649-2.patch267 bytes
sorabh.v6’s picture

sorabh.v6
He/His
Primary language Hindi
commented
Assigned: Unassigned » sorabh.v6
sorabh.v6’s picture

sorabh.v6
He/His
Primary language Hindi
commented
Assigned: sorabh.v6 » Unassigned
StatusFileSize
new add_permissions.2924649-interdiff-2-4.txt324 bytes
new add_permissions.2924649-4.patch256 bytes
new Screen Shot 2018-01-29 at 3.48.38 PM.png20.97 KB

Patch in #2 did not created the permission.yml file which right now do not exist in the repo. Updated the patch to create the permission.yml file. And then I reviewed the patch and its creating the required permission. Please refer attached image -

Status: Needs review » Needs work

The last submitted patch, 4: add_permissions.2924649-4.patch, failed testing. View results

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs work » Reviewed & tested by the community

Passes

  • mglaman committed a955cc7 on 8.x-1.x authored by sorabh.v6 
    Issue #2924649 by sorabh.v6, chrisrockwell: Add permissions - access...
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.